Bug 120377 - SVG clipping, masking, and gradients-on-text do not respect the device scale factor
Summary: SVG clipping, masking, and gradients-on-text do not respect the device scale ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: SVG (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-27 14:54 PDT by Tim Horton
Modified: 2013-08-29 17:07 PDT (History)
17 users (show)

See Also:

Attachments
testcase (2.78 KB, text/html)
2013-08-27 14:54 PDT, Tim Horton 		no flags Details
screenshot of test case (71.38 KB, image/png)
2013-08-27 14:55 PDT, Tim Horton 		no flags Details
prelim (3.75 KB, patch)
2013-08-27 15:35 PDT, Tim Horton 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
patch (6.08 KB, patch)
2013-08-29 16:06 PDT, Tim Horton 		simon.fraser: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-08-27 14:54:35 PDT 
See the attached test case.

calculateTransformationToOutermostCoordinateSystem, which we frequently use to find the transform to map rects through for creation of image buffers, doesn't respect the device scale factor, leading to blurry rendering in HiDPI contexts.

<rdar://problem/14777944>
Comment 1 Tim Horton 2013-08-27 14:54:53 PDT 
Created attachment 209803 [details]
testcase
Comment 2 Tim Horton 2013-08-27 14:55:19 PDT 
Created attachment 209804 [details]
screenshot of test case
Comment 3 Tim Horton 2013-08-27 15:35:37 PDT 
Created attachment 209812 [details]
prelim

have to go work on something else but here's where we're at
Comment 4 Early Warning System Bot 2013-08-29 15:31:36 PDT 
Comment on attachment 209812 [details]
prelim

Attachment 209812 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1623716
Comment 5 Early Warning System Bot 2013-08-29 15:32:35 PDT 
Comment on attachment 209812 [details]
prelim

Attachment 209812 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1643099
Comment 6 EFL EWS Bot 2013-08-29 16:04:26 PDT 
Comment on attachment 209812 [details]
prelim

Attachment 209812 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1635358
Comment 7 Tim Horton 2013-08-29 16:06:39 PDT 
Created attachment 210042 [details]
patch
Comment 8 Tim Horton 2013-08-29 16:20:09 PDT 
Comment on attachment 210042 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=210042&action=review

> Source/WebCore/rendering/svg/SVGRenderingContext.cpp:35
> +#include "RenderLayerBacking.h"

I don’t need this anymore.
Comment 9 Tim Horton 2013-08-29 17:07:56 PDT 
https://trac.webkit.org/r154856