Bug 120376 - Stop using deleteAllValues in CClass
Summary: Stop using deleteAllValues in CClass
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Anders Carlsson
URL:
Keywords:
Depends on: 120398
Blocks:
  Show dependency treegraph
 
Reported: 2013-08-27 14:18 PDT by Anders Carlsson
Modified: 2013-08-28 02:59 PDT (History)
6 users (show)

See Also:


Attachments
Patch (4.42 KB, patch)
2013-08-27 14:21 PDT, Anders Carlsson
kling: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2013-08-27 14:18:32 PDT
Stop using deleteAllValues in CClass
Comment 1 Anders Carlsson 2013-08-27 14:21:13 PDT
Created attachment 209801 [details]
Patch
Comment 2 Andreas Kling 2013-08-27 14:22:36 PDT
Comment on attachment 209801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209801&action=review

k

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

OOPS
Comment 3 Anders Carlsson 2013-08-27 14:25:58 PDT
Committed r154708: <http://trac.webkit.org/changeset/154708>
Comment 4 Darin Adler 2013-08-27 14:59:11 PDT
Comment on attachment 209801 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209801&action=review

> Source/WebCore/bridge/c/c_class.cpp:101
> +        OwnPtr<Field> field = adoptPtr(new CField(ident));
> +        m_fields.set(name.impl(), field.release());

This would read better without the local variable and without the release().