RESOLVED FIXED 120376
Stop using deleteAllValues in CClass 
https://bugs.webkit.org/show_bug.cgi?id=120376
Summary Stop using deleteAllValues in CClass
Anders Carlsson
Reported 2013-08-27 14:18:32 PDT
Stop using deleteAllValues in CClass
Attachments
Patch (4.42 KB, patch)
2013-08-27 14:21 PDT, Anders Carlsson 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Anders Carlsson
Comment 1 2013-08-27 14:21:13 PDT
Created attachment 209801 [details] Patch
Andreas Kling
Comment 2 2013-08-27 14:22:36 PDT
Comment on attachment 209801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209801&action=review k > Source/WebCore/ChangeLog:8 > + No new tests (OOPS!). OOPS
Anders Carlsson
Comment 3 2013-08-27 14:25:58 PDT
Committed r154708: <http://trac.webkit.org/changeset/154708>
Darin Adler
Comment 4 2013-08-27 14:59:11 PDT
Comment on attachment 209801 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209801&action=review > Source/WebCore/bridge/c/c_class.cpp:101 > + OwnPtr<Field> field = adoptPtr(new CField(ident)); > + m_fields.set(name.impl(), field.release()); This would read better without the local variable and without the release().
Note You need to log in before you can comment on or make changes to this bug.