Bug 120370 - AppleWin port should delete sem lock files in /dev/shm during cleanup tasks for NRWT
Summary: AppleWin port should delete sem lock files in /dev/shm during cleanup tasks f...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-27 11:45 PDT by Roger Fong
Modified: 2013-08-27 12:41 PDT (History)
6 users (show)

See Also:


Attachments
patch (1.48 KB, patch)
2013-08-27 11:55 PDT, Roger Fong
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2013-08-27 11:45:39 PDT
With our current version of cygwin and python there is a bug where the sem lock files do not get removed from /dev/shm.
/dev/shm eventually fills up with tons of sem lock files and we issues where we get "OSError raised: [Errno 17] File exists" due to file collisions.

However, installing other versions of cygwin/python would lead to tons of other issues which we've previously discovered so we just need to work around this issue here.
Comment 1 Roger Fong 2013-08-27 11:55:19 PDT
Created attachment 209789 [details]
patch
Comment 2 Roger Fong 2013-08-27 11:55:39 PDT
tested this fix locally on a bot that had this issue, and it did the trick
Comment 3 Brent Fulgham 2013-08-27 11:58:11 PDT
Comment on attachment 209789 [details]
patch

This looks great!  Does this cleanup code get called at startup of the test harness, or only when ending tests?

If it doesn't, maybe we could add a belt-and-suspenders step to kill any locks when the test rig is first started?
Comment 4 Dirk Pranke 2013-08-27 12:14:58 PDT
cleanup_test_run() does not get called at startup. setup_test_run() (right above in the code) does :).
Comment 5 Roger Fong 2013-08-27 12:36:08 PDT
(In reply to comment #4)
> cleanup_test_run() does not get called at startup. setup_test_run() (right above in the code) does :).

O cool, I'll move it there. Thanks!
Comment 6 Roger Fong 2013-08-27 12:41:39 PDT
<rdar://problem/14621844>

Committed: http://trac.webkit.org/changeset/154704