With our current version of cygwin and python there is a bug where the sem lock files do not get removed from /dev/shm.
/dev/shm eventually fills up with tons of sem lock files and we issues where we get "OSError raised: [Errno 17] File exists" due to file collisions.
However, installing other versions of cygwin/python would lead to tons of other issues which we've previously discovered so we just need to work around this issue here.
Created attachment 209789 [details]
tested this fix locally on a bot that had this issue, and it did the trick
Comment on attachment 209789 [details]
This looks great! Does this cleanup code get called at startup of the test harness, or only when ending tests?
If it doesn't, maybe we could add a belt-and-suspenders step to kill any locks when the test rig is first started?
cleanup_test_run() does not get called at startup. setup_test_run() (right above in the code) does :).
(In reply to comment #4)
> cleanup_test_run() does not get called at startup. setup_test_run() (right above in the code) does :).
O cool, I'll move it there. Thanks!