Bug 120367 - No need for generalPasteboard (aside from "global selection mode")
Summary: No need for generalPasteboard (aside from "global selection mode")
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks: 120392
  Show dependency tree / graph
 
Reported: 2013-08-27 10:04 PDT by Darin Adler
Modified: 2013-08-27 22:02 PDT (History)
2 users (show)

See Also:

Attachments
Patch (5.91 KB, patch)
2013-08-27 10:06 PDT, Darin Adler 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-08-27 10:04:00 PDT 
No need for generalPasteboard (aside from "global selection mode")
Comment 1 Darin Adler 2013-08-27 10:06:38 PDT 
Created attachment 209783 [details]
Patch
Comment 2 Alexey Proskuryakov 2013-08-27 10:36:12 PDT 
I got confused by your IRC statement that this patch fixes the root cause of bug 113094, so I'd like to chat about how pasteboard works (especially as I'm going to look into drag&drop handling in WKTR soon).
Comment 3 Build Bot 2013-08-27 11:45:48 PDT 
Comment on attachment 209783 [details]
Patch

Attachment 209783 [details] did not pass win-ews (win):
Output: http://webkit-queues.appspot.com/results/1594008
Comment 4 Alexey Proskuryakov 2013-08-27 11:59:45 PDT 
Comment on attachment 209783 [details]
Patch

r=me

I think that ultimately, using the same class for long-living Pasteboard handles (like those inside Clipboard object) and for these single-shot ones is confusing. We need to keep changeCount updated for Clipboard but don't care about it here.
Comment 5 Darin Adler 2013-08-27 15:02:03 PDT 
Comment on attachment 209783 [details]
Patch

Windows build failures were unrelated to this patch.
Comment 6 WebKit Commit Bot 2013-08-27 15:24:17 PDT 
Comment on attachment 209783 [details]
Patch

Clearing flags on attachment: 209783

Committed r154712: <http://trac.webkit.org/changeset/154712>
Comment 7 WebKit Commit Bot 2013-08-27 15:24:18 PDT 
All reviewed patches have been landed.  Closing bug.