WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
120353
[WK2][Soup] Add WebFrameNetworkingContext::webFrameLoaderClient() after
r154490
https://bugs.webkit.org/show_bug.cgi?id=120353
Summary
[WK2][Soup] Add WebFrameNetworkingContext::webFrameLoaderClient() after r154490
Csaba Osztrogonác
Reported
2013-08-27 04:35:43 PDT
http://trac.webkit.org/changeset/154490
added WebFrameNetworkingContext::webFrameLoaderClient(), but only for Mac implementation. But it is needed by WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp unconditionally for ENABLE_NETWORK_PROCESS builds. So we should add it to Soup implementation too.
Attachments
Patch
(3.06 KB, patch)
2013-08-27 04:38 PDT
,
Csaba Osztrogonác
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1
2013-08-27 04:38:25 PDT
Created
attachment 209745
[details]
Patch
Alexey Proskuryakov
Comment 2
2013-08-27 10:40:17 PDT
Comment on
attachment 209745
[details]
Patch Unsure why this code can't be cross-platform (I guess I subconsciously expected it to be).
WebKit Commit Bot
Comment 3
2013-08-27 11:01:43 PDT
Comment on
attachment 209745
[details]
Patch Clearing flags on attachment: 209745 Committed
r154699
: <
http://trac.webkit.org/changeset/154699
>
WebKit Commit Bot
Comment 4
2013-08-27 11:01:47 PDT
All reviewed patches have been landed. Closing bug.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug