Bug 120353 - [WK2][Soup] Add WebFrameNetworkingContext::webFrameLoaderClient() after r154490
Summary: [WK2][Soup] Add WebFrameNetworkingContext::webFrameLoaderClient() after r154490
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
Depends on:
Blocks: 108832 120186
  Show dependency treegraph
Reported: 2013-08-27 04:35 PDT by Csaba Osztrogonác
Modified: 2013-08-27 11:01 PDT (History)
4 users (show)

See Also:

Patch (3.06 KB, patch)
2013-08-27 04:38 PDT, Csaba Osztrogonác
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2013-08-27 04:35:43 PDT
http://trac.webkit.org/changeset/154490 added WebFrameNetworkingContext::webFrameLoaderClient(), but only 
for Mac implementation. But it is needed by WebKit2/WebProcess/WebCoreSupport/WebPlatformStrategies.cpp
unconditionally for ENABLE_NETWORK_PROCESS builds. So we should add it to Soup implementation too.
Comment 1 Csaba Osztrogonác 2013-08-27 04:38:25 PDT
Created attachment 209745 [details]
Comment 2 Alexey Proskuryakov 2013-08-27 10:40:17 PDT
Comment on attachment 209745 [details]

Unsure why this code can't be cross-platform (I guess I subconsciously expected it to be).
Comment 3 WebKit Commit Bot 2013-08-27 11:01:43 PDT
Comment on attachment 209745 [details]

Clearing flags on attachment: 209745

Committed r154699: <http://trac.webkit.org/changeset/154699>
Comment 4 WebKit Commit Bot 2013-08-27 11:01:47 PDT
All reviewed patches have been landed.  Closing bug.