Bug 120351 - Add USE(PROTECTION_SPACE_AUTH_CALLBACK) guards to canAuthenticateAgainstProtectionSpace()
Summary: Add USE(PROTECTION_SPACE_AUTH_CALLBACK) guards to canAuthenticateAgainstProte...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 108832
  Show dependency tree / graph
 
Reported: 2013-08-27 03:06 PDT by Csaba Osztrogonác
Modified: 2013-08-30 10:49 PDT (History)
7 users (show)

See Also:

Attachments
Patch (6.83 KB, patch)
2013-08-27 03:08 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2013-08-27 03:06:52 PDT 
virtual void NetworkLoaderClient::canAuthenticateAgainstProtectionSpace(NetworkResourceLoader*, const WebCore::ProtectionSpace&) = 0;
is implemented by AsynchronousNetworkLoaderClient and SynchronousNetworkLoaderClient.

- AsynchronousNetworkLoaderClient implementation uses Messages::WebResourceLoader::CanAuthenticateAgainstProtectionSpace()
- SynchronousNetworkLoaderClient implementation uses NetworkResourceLoader::continueCanAuthenticateAgainstProtectionSpace()

Both of them are inside USE(PROTECTION_SPACE_AUTH_CALLBACK), 
so all functions use them should be inside the same if guard.
Comment 1 Csaba Osztrogonác 2013-08-27 03:08:33 PDT 
Created attachment 209739 [details]
Patch
Comment 2 Csaba Osztrogonác 2013-08-30 10:02:37 PDT 
ping for review, please :)
Comment 3 WebKit Commit Bot 2013-08-30 10:49:51 PDT 
Comment on attachment 209739 [details]
Patch

Clearing flags on attachment: 209739

Committed r154895: <http://trac.webkit.org/changeset/154895>
Comment 4 WebKit Commit Bot 2013-08-30 10:49:53 PDT 
All reviewed patches have been landed.  Closing bug.