Bug 120342 - [EFL] Change the path of test font from tarball to git
Summary: [EFL] Change the path of test font from tarball to git
Status: RESOLVED LATER
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gyuyoung Kim
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-27 00:40 PDT by Gyuyoung Kim
Modified: 2013-08-27 19:00 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.73 KB, patch)
2013-08-27 00:41 PDT, Gyuyoung Kim
buildbot: commit-queue-
Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion (528.76 KB, application/zip)
2013-08-27 01:50 PDT, Build Bot
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gyuyoung Kim 2013-08-27 00:40:06 PDT
Thanks to mrobinson, we can use git repository to download the test font. I think it would be good to use git instead of tarball.
Comment 1 Gyuyoung Kim 2013-08-27 00:41:46 PDT
Created attachment 209718 [details]
Patch
Comment 2 Chris Dumez 2013-08-27 00:41:58 PDT
We intentionally did not use git in jhbuild in the past because it was causing bot failures when internet was down on the bots. Are we sure we want to do this now?
Comment 3 Chris Dumez 2013-08-27 00:45:45 PDT
For the record, the issue was experienced on the Intel bots which are down now. Those bots were frequently losing their internet connectivity for some reason.

I do not know how stable the internet connectivity is on the remaining Samsung bots. You probably know better than me since you are managing them.

So I don't mind r+'ing this if you're confident this won't cause bot failures.
Comment 4 Gyuyoung Kim 2013-08-27 00:56:42 PDT
(In reply to comment #2)
> We intentionally did not use git in jhbuild in the past because it was causing bot failures when internet was down on the bots. Are we sure we want to do this now?

As you know, other module(libseccomp) already have used git. Besides if internet is down on the bots, we have no choice but to stop all build and regression tests. However, I believe our bots will not down internet, as you may know, we use Amazon EC2.
Comment 5 Chris Dumez 2013-08-27 00:58:37 PDT
Comment on attachment 209718 [details]
Patch

Are you sure no tests need rebaselining since you're using a newer font package?
Comment 6 Gyuyoung Kim 2013-08-27 00:59:25 PDT
(In reply to comment #5)
> (From update of attachment 209718 [details])
> Are you sure no tests need rebaselining since you're using a newer font package?

Ok, I will land this patch after checking it on my local env.
Comment 7 Build Bot 2013-08-27 01:49:58 PDT
Comment on attachment 209718 [details]
Patch

Attachment 209718 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1584210

New failing tests:
fast/workers/termination-with-port-messages.html
Comment 8 Build Bot 2013-08-27 01:50:00 PDT
Created attachment 209728 [details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-06  Port: mac-mountainlion  Platform: Mac OS X 10.8.4
Comment 9 Gyuyoung Kim 2013-08-27 18:59:52 PDT
There are a lots of regression when we use new test font. I will replace font with this patch when we have obvious reason.