WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED LATER
120342
[EFL] Change the path of test font from tarball to git
https://bugs.webkit.org/show_bug.cgi?id=120342
Summary
[EFL] Change the path of test font from tarball to git
Gyuyoung Kim
Reported
2013-08-27 00:40:06 PDT
Thanks to mrobinson, we can use git repository to download the test font. I think it would be good to use git instead of tarball.
Attachments
Patch
(1.73 KB, patch)
2013-08-27 00:41 PDT
,
Gyuyoung Kim
buildbot
: commit-queue-
Details
Formatted Diff
Diff
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion
(528.76 KB, application/zip)
2013-08-27 01:50 PDT
,
Build Bot
no flags
Details
View All
Add attachment
proposed patch, testcase, etc.
Gyuyoung Kim
Comment 1
2013-08-27 00:41:46 PDT
Created
attachment 209718
[details]
Patch
Chris Dumez
Comment 2
2013-08-27 00:41:58 PDT
We intentionally did not use git in jhbuild in the past because it was causing bot failures when internet was down on the bots. Are we sure we want to do this now?
Chris Dumez
Comment 3
2013-08-27 00:45:45 PDT
For the record, the issue was experienced on the Intel bots which are down now. Those bots were frequently losing their internet connectivity for some reason. I do not know how stable the internet connectivity is on the remaining Samsung bots. You probably know better than me since you are managing them. So I don't mind r+'ing this if you're confident this won't cause bot failures.
Gyuyoung Kim
Comment 4
2013-08-27 00:56:42 PDT
(In reply to
comment #2
)
> We intentionally did not use git in jhbuild in the past because it was causing bot failures when internet was down on the bots. Are we sure we want to do this now?
As you know, other module(libseccomp) already have used git. Besides if internet is down on the bots, we have no choice but to stop all build and regression tests. However, I believe our bots will not down internet, as you may know, we use Amazon EC2.
Chris Dumez
Comment 5
2013-08-27 00:58:37 PDT
Comment on
attachment 209718
[details]
Patch Are you sure no tests need rebaselining since you're using a newer font package?
Gyuyoung Kim
Comment 6
2013-08-27 00:59:25 PDT
(In reply to
comment #5
)
> (From update of
attachment 209718
[details]
) > Are you sure no tests need rebaselining since you're using a newer font package?
Ok, I will land this patch after checking it on my local env.
Build Bot
Comment 7
2013-08-27 01:49:58 PDT
Comment on
attachment 209718
[details]
Patch
Attachment 209718
[details]
did not pass mac-ews (mac): Output:
http://webkit-queues.appspot.com/results/1584210
New failing tests: fast/workers/termination-with-port-messages.html
Build Bot
Comment 8
2013-08-27 01:50:00 PDT
Created
attachment 209728
[details]
Archive of layout-test-results from webkit-ews-06 for mac-mountainlion The attached test failures were seen while running run-webkit-tests on the mac-ews. Bot: webkit-ews-06 Port: mac-mountainlion Platform: Mac OS X 10.8.4
Gyuyoung Kim
Comment 9
2013-08-27 18:59:52 PDT
There are a lots of regression when we use new test font. I will replace font with this patch when we have obvious reason.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug