RESOLVED FIXED 120339
FocusController::focusedOrMainFrame() should return a reference. 
https://bugs.webkit.org/show_bug.cgi?id=120339
Summary FocusController::focusedOrMainFrame() should return a reference.
Andreas Kling
Reported 2013-08-26 20:33:09 PDT
FocusController::focusedOrMainFrame() should return a reference.
Attachments
Patch (120.44 KB, patch)
2013-08-26 20:37 PDT, Andreas Kling 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch (120.58 KB, patch)
2013-08-26 20:53 PDT, Andreas Kling 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch (120.77 KB, patch)
2013-08-26 21:05 PDT, Andreas Kling 		eflews.bot: commit-queue-
DetailsFormatted DiffDiff
Patch (121.60 KB, patch)
2013-08-27 05:18 PDT, Andreas Kling 		koivisto: review+
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-08-26 20:37:26 PDT
Created attachment 209711 [details] Patch I'm sure EWS will hate it. I like it though.
Early Warning System Bot
Comment 2 2013-08-26 20:42:31 PDT
Comment on attachment 209711 [details] Patch Attachment 209711 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1590139
EFL EWS Bot
Comment 3 2013-08-26 20:42:56 PDT
Comment on attachment 209711 [details] Patch Attachment 209711 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1578160
Early Warning System Bot
Comment 4 2013-08-26 20:42:59 PDT
Comment on attachment 209711 [details] Patch Attachment 209711 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1582153
Andreas Kling
Comment 5 2013-08-26 20:53:35 PDT
Created attachment 209713 [details] Patch
Early Warning System Bot
Comment 6 2013-08-26 20:58:27 PDT
Comment on attachment 209713 [details] Patch Attachment 209713 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1589136
EFL EWS Bot
Comment 7 2013-08-26 20:58:59 PDT
Comment on attachment 209713 [details] Patch Attachment 209713 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1581145
Early Warning System Bot
Comment 8 2013-08-26 20:59:18 PDT
Comment on attachment 209713 [details] Patch Attachment 209713 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1586135
kov's GTK+ EWS bot
Comment 9 2013-08-26 21:00:54 PDT
Comment on attachment 209713 [details] Patch Attachment 209713 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1578166
Andreas Kling
Comment 10 2013-08-26 21:05:16 PDT
Created attachment 209714 [details] Patch
EFL EWS Bot
Comment 11 2013-08-26 21:11:20 PDT
Comment on attachment 209714 [details] Patch Attachment 209714 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1578170
Early Warning System Bot
Comment 12 2013-08-26 21:11:44 PDT
Comment on attachment 209714 [details] Patch Attachment 209714 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1583139
Darin Adler
Comment 13 2013-08-26 21:50:16 PDT
/mnt/eflews/webkit/WebKit/Source/WebKit/efl/ewk/ewk_view.cpp: In function 'Evas_Object* ewk_view_frame_focused_get(const Evas_Object*)': /mnt/eflews/webkit/WebKit/Source/WebKit/efl/ewk/ewk_view.cpp:1400:94: error: request for member 'loader' in 'core', which is of pointer type 'WebCore::Frame*' (maybe you meant to use '->' ?) /home/webkit/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp: In member function 'WebKit::EditorState WebKit::WebPage::editorState() const': /home/webkit/WebKit/Source/WebKit2/WebProcess/WebPage/WebPage.cpp:615:35: error: base operand of '->' has non-pointer type 'WebCore::Frame' and more of the same
Build Bot
Comment 14 2013-08-27 04:10:49 PDT
Comment on attachment 209714 [details] Patch Attachment 209714 [details] did not pass win-ews (win): Output: http://webkit-queues.appspot.com/results/1579257
Andreas Kling
Comment 15 2013-08-27 05:18:34 PDT
Created attachment 209750 [details] Patch
Antti Koivisto
Comment 16 2013-08-27 05:51:46 PDT
Comment on attachment 209750 [details] Patch r=me
Andreas Kling
Comment 17 2013-08-27 05:59:41 PDT
Committed r154678: <http://trac.webkit.org/changeset/154678>
Note You need to log in before you can comment on or make changes to this bug.