Bug 120337 – CMakeLists.txt for EFL port contains files not required by build process.

• Status: RESOLVED
• Resolution: INVALID
• Component: WebKit EFL

[Michał Poteralski]

CMakeLists: Source/WebCore/platform/efl/DefaultTheme/CMakeLists.txt contains files not required by build process. 
There are *.edc and *.png files that are not necessary. All .edc files required by build process should be contained only in default.edc file.

[Gyuyoung Kim]

(In reply to comment #0)
> CMakeLists: Source/WebCore/platform/efl/DefaultTheme/CMakeLists.txt contains files not required by build process. 
> There are *.edc and *.png files that are not necessary. All .edc files required by build process should be contained only in default.edc file.

I noticed it before. Go ahead !

[Michał Poteralski]

Created attachment 209706 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 209706 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209706&action=review

> Source/WebCore/ChangeLog:7
> +

Missing patch description.

> Source/WebCore/ChangeLog:8
> +        No new tests (OOPS!).

If patch doesn't influence on behavior, remove this line. or you can mention as below,

No new tests, no behavior change.

[Michał Poteralski]

Created attachment 209708 [details]
Patch

[Gyuyoung Kim]

Comment on attachment 209708 [details]
Patch

r=me, but Ryuan wanted to check if there is no problem before landing.

[Ryuan Choi]

Comment on attachment 209708 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209708&action=review

> Source/WebCore/ChangeLog:11
> +        I've removed not required *.edc and *.png dependencies from the CMakeLists.txt file for EFL port.
> +        All *.edc files required during build process should be contained in default.edc file only.
> +
> +        No new tests, no behaviour change.

No, We need them for partial build(normally we are doing).

If we remove them from dependency, CMake can not detect whether they are changed until we compiles all.

[Gyuyoung Kim]

(In reply to comment #6)
> (From update of attachment 209708 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=209708&action=review
> 
> > Source/WebCore/ChangeLog:11
> > +        I've removed not required *.edc and *.png dependencies from the CMakeLists.txt file for EFL port.
> > +        All *.edc files required during build process should be contained in default.edc file only.
> > +
> > +        No new tests, no behaviour change.
> 
> No, We need them for partial build(normally we are doing).
> 
> If we remove them from dependency, CMake can not detect whether they are changed until we compiles all.

Ah, I missed it. Thank you for checking it.