Bug 120332 - Web Inspector: Remove harmless assert, triggered hitting breakpoint in auto prettyprinted code on reload
Summary: Web Inspector: Remove harmless assert, triggered hitting breakpoint in auto p...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Inspector (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Joseph Pecoraro
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-26 17:00 PDT by Joseph Pecoraro
Modified: 2013-09-05 15:10 PDT (History)
5 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.82 KB, patch)
2013-08-26 17:01 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-08-26 17:00:46 PDT 
* STEPS TO REPRODUCE
1. Inspect <http://bogojoker.com/shell/>
2. Set a breakpoint on pretty printed easySlider.min.js that would be hit on reload
3. Reload
  => console.assert in console when file is auto-pretty printed without execution line handle.
Comment 1 Radar WebKit Bug Importer 2013-08-26 17:01:19 PDT 
<rdar://problem/14840428>
Comment 2 Joseph Pecoraro 2013-08-26 17:01:52 PDT 
Created attachment 209693 [details]
[PATCH] Proposed Fix
Comment 3 Joseph Pecoraro 2013-08-26 17:02:30 PDT 
This assert doesn't really matter either. By the end of the function, if newExecutionLocation we re-generate the executionLineHandle when setting the new executionLineNumber.
Comment 4 WebKit Commit Bot 2013-09-05 15:10:30 PDT 
Comment on attachment 209693 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 209693

Committed r155154: <http://trac.webkit.org/changeset/155154>
Comment 5 WebKit Commit Bot 2013-09-05 15:10:32 PDT 
All reviewed patches have been landed.  Closing bug.