Bug 120329 - REGRESSION(r154640): Caused flaky crashes on a lot of editing tests (Requested by rniwa on #webkit).
Summary: REGRESSION(r154640): Caused flaky crashes on a lot of editing tests (Requeste...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: WebKit Commit Bot
URL:
Keywords:
Depends on:
Blocks: 81419
  Show dependency tree / graph
 
Reported: 2013-08-26 16:03 PDT by WebKit Commit Bot
Modified: 2013-08-26 16:24 PDT (History)
2 users (show)

See Also:

Attachments
ROLLOUT of r154640 (18.83 KB, patch)
2013-08-26 16:03 PDT, WebKit Commit Bot 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description WebKit Commit Bot 2013-08-26 16:03:23 PDT 
http://trac.webkit.org/changeset/154640 broke the build:
Caused flaky crashes on a lot of editing tests (Requested by rniwa on #webkit).

This is an automatic bug report generated by the sheriff-bot. If this bug
report was created because of a flaky test, please file a bug for the flaky
test (if we don't already have one on file) and dup this bug against that bug
so that we can track how often these flaky tests case pain.

"Only you can prevent forest fires." -- Smokey the Bear
Comment 1 WebKit Commit Bot 2013-08-26 16:03:48 PDT 
Created attachment 209687 [details]
ROLLOUT of r154640

Any committer can land this patch automatically by marking it commit-queue+.  The commit-queue will build and test the patch before landing to ensure that the rollout will be successful.  This process takes approximately 15 minutes.

If you would like to land the rollout faster, you can use the following command:

  webkit-patch land-attachment ATTACHMENT_ID

where ATTACHMENT_ID is the ID of this attachment.
Comment 2 Alexey Proskuryakov 2013-08-26 16:11:28 PDT 
I see some crashes locally on another machine (strangely, not on the one where I developed this). It may be that it's actually the missing [super init] call. Same that we had in WebKit1 without any issues since 2006, and which Andy fixed a few moments ago.

Will test this hypothesis quickly.
Comment 3 Alexey Proskuryakov 2013-08-26 16:18:53 PDT 
Comment on attachment 209687 [details]
ROLLOUT of r154640

No, an -init doesn't seem to help. Rolling out for now.
Comment 4 WebKit Commit Bot 2013-08-26 16:24:22 PDT 
Comment on attachment 209687 [details]
ROLLOUT of r154640

Clearing flags on attachment: 209687

Committed r154650: <http://trac.webkit.org/changeset/154650>
Comment 5 WebKit Commit Bot 2013-08-26 16:24:24 PDT 
All reviewed patches have been landed.  Closing bug.