RESOLVED FIXED 120319
PageGroup::groupSettings() should return a reference 
https://bugs.webkit.org/show_bug.cgi?id=120319
Summary PageGroup::groupSettings() should return a reference
Pratik Solanki
Reported 2013-08-26 10:35:00 PDT
PageGroup always has m_groupSettings. We should return a reference from that method.
Attachments
Patch (10.24 KB, patch)
2013-08-26 10:37 PDT, Pratik Solanki 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2013-08-26 10:37:52 PDT
Created attachment 209664 [details] Patch
Andreas Kling
Comment 2 2013-08-26 10:39:09 PDT
Comment on attachment 209664 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=209664&action=review LGTM. > Source/WebCore/page/PageGroup.h:111 > - GroupSettings* groupSettings() const { return m_groupSettings.get(); } > + GroupSettings& groupSettings() const { return *m_groupSettings; } We should also make m_groupSettings a const OwnPtr.
Pratik Solanki
Comment 3 2013-08-26 10:56:07 PDT
Committed r154618: <http://trac.webkit.org/changeset/154618>
Note You need to log in before you can comment on or make changes to this bug.