Bug 120319 - PageGroup::groupSettings() should return a reference
Summary: PageGroup::groupSettings() should return a reference
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Pratik Solanki
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-26 10:35 PDT by Pratik Solanki
Modified: 2013-08-26 10:56 PDT (History)
2 users (show)

See Also:

Attachments
Patch (10.24 KB, patch)
2013-08-26 10:37 PDT, Pratik Solanki 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Pratik Solanki 2013-08-26 10:35:00 PDT 
PageGroup always has m_groupSettings. We should return  a reference from that method.
Comment 1 Pratik Solanki 2013-08-26 10:37:52 PDT 
Created attachment 209664 [details]
Patch
Comment 2 Andreas Kling 2013-08-26 10:39:09 PDT 
Comment on attachment 209664 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209664&action=review

LGTM.

> Source/WebCore/page/PageGroup.h:111
> -        GroupSettings* groupSettings() const { return m_groupSettings.get(); }
> +        GroupSettings& groupSettings() const { return *m_groupSettings; }

We should also make m_groupSettings a const OwnPtr.
Comment 3 Pratik Solanki 2013-08-26 10:56:07 PDT 
Committed r154618: <http://trac.webkit.org/changeset/154618>