Bug 12031 – Update embedded JavaScriptCore/pcre library from 6.1 to 6.2

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[David Kilzer (:ddkilzer)]

The current embedded JavaScriptCore/pcre library is version 6.1 (r10495) with some fixes from version 6.2 included in r14736.

I'm wondering if I should continue this work?  Various enhancements and bug fixes have been included in versions 6.3-6.7 and 7.0.

[David Kilzer (:ddkilzer)]

Created attachment 12114 [details]
Full pcre-6.1 to 6.2 diff

Full diff between pcre-6.1 and 6.2 for reference.

[David Kilzer (:ddkilzer)]

Created attachment 12115 [details]
Patch v1

Brings JavaScriptCore/pcre up to version 6.2.

[Geoffrey Garen]

Comment on attachment 12115 [details]
Patch v1

r=me (assuming the layout tests and javascriptcore tests pass).

It would be nice to keep in step with PCRE, and upgrade to 7.x. The only reason we don't keep in lockstep is that it can be a lot of work to port PCRE to use UTF16 strings.

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> (From update of attachment 12115 [details] [edit])
> r=me (assuming the layout tests and javascriptcore tests pass).

No regressions in layout tests or javascriptcore tests.  Committed revision 18483.