RESOLVED FIXED Bug 120299
[GTK][WK2] a11y tests unconditionally launching a11y daemons 
https://bugs.webkit.org/show_bug.cgi?id=120299
Summary [GTK][WK2] a11y tests unconditionally launching a11y daemons
Sergio Villar Senin
Reported 2013-08-26 04:05:53 PDT
I was checking the status of some GTK bots and I noticed that we had >600!!! at-spi2-bus-launcher processes with their corresponding dbus-daemon processes I think the problem is that we unconditionally launch them in _start_accessibility_daemons() in run-gtk-tests
Attachments
Patch proposal (2.26 KB, patch)
2013-09-04 09:30 PDT, Mario Sanchez Prada 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Mario Sanchez Prada
Comment 1 2013-09-04 09:30:08 PDT
Created attachment 210470 [details] Patch proposal (In reply to comment #0) > I was checking the status of some GTK bots and I noticed that we had >600!!! at-spi2-bus-launcher processes with their corresponding dbus-daemon processes > > I think the problem is that we unconditionally launch them in _start_accessibility_daemons() in run-gtk-tests Actually, this should not be an issue since we already take care of terminating the process that we start in _tear_down_testing_environment(). The problem was that, as silly as it might sound, we were using the wrong variable name (_ally_bus_launcher) to keep a reference to that process, so later on we were not terminating it properly (as we were expecting _spi_bus_launcher in _tear_down_testing_environment()).
WebKit Commit Bot
Comment 2 2013-09-12 04:14:49 PDT
Comment on attachment 210470 [details] Patch proposal Clearing flags on attachment: 210470 Committed r155606: <http://trac.webkit.org/changeset/155606>
WebKit Commit Bot
Comment 3 2013-09-12 04:14:51 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.