Bug 120299 - [GTK][WK2] a11y tests unconditionally launching a11y daemons
Summary: [GTK][WK2] a11y tests unconditionally launching a11y daemons
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-26 04:05 PDT by Sergio Villar Senin
Modified: 2013-09-12 04:14 PDT (History)
5 users (show)

See Also:


Attachments
Patch proposal (2.26 KB, patch)
2013-09-04 09:30 PDT, Mario Sanchez Prada
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Sergio Villar Senin 2013-08-26 04:05:53 PDT
I was checking the status of some GTK bots and I noticed that we had >600!!! at-spi2-bus-launcher processes with their corresponding dbus-daemon processes

I think the problem is that we unconditionally launch them in _start_accessibility_daemons() in run-gtk-tests
Comment 1 Mario Sanchez Prada 2013-09-04 09:30:08 PDT
Created attachment 210470 [details]
Patch proposal

(In reply to comment #0)
> I was checking the status of some GTK bots and I noticed that we had >600!!! at-spi2-bus-launcher processes with their corresponding dbus-daemon processes
> 
> I think the problem is that we unconditionally launch them in _start_accessibility_daemons() in run-gtk-tests

Actually, this should not be an issue since we already take care of terminating the process that we start in _tear_down_testing_environment().

The problem was that, as silly as it might sound, we were using the wrong variable name (_ally_bus_launcher) to keep a reference to that process, so later on we were not terminating it properly (as we were expecting _spi_bus_launcher in _tear_down_testing_environment()).
Comment 2 WebKit Commit Bot 2013-09-12 04:14:49 PDT
Comment on attachment 210470 [details]
Patch proposal

Clearing flags on attachment: 210470

Committed r155606: <http://trac.webkit.org/changeset/155606>
Comment 3 WebKit Commit Bot 2013-09-12 04:14:51 PDT
All reviewed patches have been landed.  Closing bug.