Bug 120295 – Active WebSocket should send closing handshake to server on page navigation or page close

• Status: NEW
• Component: WebCore Misc.

[Vivek Galatage]

With a active websocket, when page navigates or page closes, the connection to the web server is terminated but 
the closing handshake is not sent. 

Specification URL: http://dev.w3.org/html5/websockets/#garbage-collection

Blink review URLs:
https://codereview.chromium.org/23201008
https://codereview.chromium.org/23069004/

Patch follows.

[Vivek Galatage]

Created attachment 209632 [details]
Patch

[Build Bot]

Comment on attachment 209632 [details]
Patch

Attachment 209632 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1574017

New failing tests:
http/tests/websocket/tests/hybi/url-no-trailing-slash.html
http/tests/websocket/tests/hybi/broken-utf8.html
http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked.html

[Build Bot]

Created attachment 209636 [details]
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion

The attached test failures were seen while running run-webkit-tests on the mac-ews.
Bot: webkit-ews-07  Port: mac-mountainlion  Platform: Mac OS X 10.8.4

[Vivek Galatage]

(In reply to comment #2)
> (From update of attachment 209632 [details])
> Attachment 209632 [details] did not pass mac-ews (mac):
> Output: http://webkit-queues.appspot.com/results/1574017
> 
> New failing tests:
> http/tests/websocket/tests/hybi/url-no-trailing-slash.html
> http/tests/websocket/tests/hybi/broken-utf8.html
> http/tests/security/contentSecurityPolicy/connect-src-websocket-blocked.html

If I run these cases one-by-one then all of them run without crash. Any idea what must be going wrong?

[Alexey Proskuryakov]

Comment on attachment 209632 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209632&action=review

> Source/WebCore/Modules/websockets/WebSocket.cpp:491
> +        m_channel->close(WebSocketChannel::CloseEventCodeGoingAway, String());
>          m_channel->disconnect();

Maybe m_channel becomes 0 after the close() call?

[Vivek Galatage]

(In reply to comment #5)
> (From update of attachment 209632 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=209632&action=review
> 
> > Source/WebCore/Modules/websockets/WebSocket.cpp:491
> > +        m_channel->close(WebSocketChannel::CloseEventCodeGoingAway, String());
> >          m_channel->disconnect();
> 
> Maybe m_channel becomes 0 after the close() call?

I tried it by not calling disconnect() after the close() as it calls a timer function which eventually disconnects the channel. But result still remains the same.

Although while running it on Qt port for linux, all cases passed without any crash. Anything related to core platform component for Mac?