Bug 120294 - [WK2] Buildfix for non Mac platforms
Summary: [WK2] Buildfix for non Mac platforms
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Csaba Osztrogonác
URL:
Keywords:
Depends on:
Blocks: 108832
  Show dependency tree / graph
 
Reported: 2013-08-26 02:47 PDT by Csaba Osztrogonác
Modified: 2013-08-26 15:33 PDT (History)
6 users (show)

See Also:

Attachments
Patch (2.80 KB, patch)
2013-08-26 02:49 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Patch (2.73 KB, patch)
2013-08-26 14:53 PDT, Csaba Osztrogonác 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Csaba Osztrogonác 2013-08-26 02:47:27 PDT 
We should check if __MAC_OS_X_VERSION_MIN_REQUIRED macro is defined or not:

-#if __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090
+#if defined(__MAC_OS_X_VERSION_MIN_REQUIRED) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 1090

Patch is coming.
Comment 1 Csaba Osztrogonác 2013-08-26 02:49:08 PDT 
Created attachment 209630 [details]
Patch
Comment 2 Anders Carlsson 2013-08-26 08:03:32 PDT 
Comment on attachment 209630 [details]
Patch

It's probably better to use PLATFORM(MAC) here.
Comment 3 Darin Adler 2013-08-26 10:23:10 PDT 
Comment on attachment 209630 [details]
Patch

Please use PLATFORM(MAC) as suggested by Anders.
Comment 4 Csaba Osztrogonác 2013-08-26 14:53:22 PDT 
Created attachment 209680 [details]
Patch
Comment 5 WebKit Commit Bot 2013-08-26 15:33:35 PDT 
Comment on attachment 209680 [details]
Patch

Clearing flags on attachment: 209680

Committed r154646: <http://trac.webkit.org/changeset/154646>
Comment 6 WebKit Commit Bot 2013-08-26 15:33:37 PDT 
All reviewed patches have been landed.  Closing bug.