Bug 120287 - [GTK] webkitCredentialGetCredential returns a temporary in g_return_val_if_fail
Summary: [GTK] webkitCredentialGetCredential returns a temporary in g_return_val_if_fail
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
Depends on:
Reported: 2013-08-26 00:40 PDT by Carlos Garcia Campos
Modified: 2013-08-26 00:46 PDT (History)
3 users (show)

See Also:

Patch (1.27 KB, patch)
2013-08-26 00:41 PDT, Carlos Garcia Campos
pnormand: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Carlos Garcia Campos 2013-08-26 00:40:12 PDT
webkitCredentialGetCredential() is private function so we shouldn't use g_return macros, but asserts.
Comment 1 Carlos Garcia Campos 2013-08-26 00:41:58 PDT
Created attachment 209621 [details]
Comment 2 WebKit Commit Bot 2013-08-26 00:43:14 PDT
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 3 Carlos Garcia Campos 2013-08-26 00:46:59 PDT
Committed r154589: <http://trac.webkit.org/changeset/154589>