Bug 120266 - No need for isURLAllowed function in Frame
Summary: No need for isURLAllowed function in Frame
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-25 01:45 PDT by Darin Adler
Modified: 2019-07-17 13:03 PDT (History)
10 users (show)

See Also:


Attachments
Patch (13.67 KB, patch)
2013-08-25 01:52 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
Archive of layout-test-results from webkit-ews-07 for mac-mountainlion (571.27 KB, application/zip)
2013-08-25 03:07 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-04 for mac-mountainlion (498.37 KB, application/zip)
2013-08-25 04:15 PDT, Build Bot
no flags Details
Archive of layout-test-results from webkit-ews-11 for mac-mountainlion-wk2 (479.22 KB, application/zip)
2013-08-25 09:51 PDT, Build Bot
no flags Details
Patch (52.33 KB, patch)
2019-06-30 20:07 PDT, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-08-25 01:45:44 PDT
No need for isURLAllowed function in Frame
Comment 1 Darin Adler 2013-08-25 01:52:43 PDT Comment hidden (obsolete)
Comment 2 Build Bot 2013-08-25 03:07:18 PDT Comment hidden (obsolete)
Comment 3 Build Bot 2013-08-25 03:07:21 PDT Comment hidden (obsolete)
Comment 4 Andreas Kling 2013-08-25 03:52:58 PDT
Comment on attachment 209578 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209578&action=review

> Source/WebCore/html/HTMLPlugInImageElement.cpp:-175
> -    if (contentFrame() && protocolIsJavaScript(completeURL)
> -        && !document()->securityOrigin()->canAccess(contentDocument()->securityOrigin()))
> -        return false;

I suppose this check is not equivalent to the new, shared one.
Comment 5 Build Bot 2013-08-25 04:15:17 PDT Comment hidden (obsolete)
Comment 6 Build Bot 2013-08-25 04:15:21 PDT Comment hidden (obsolete)
Comment 7 Build Bot 2013-08-25 09:51:30 PDT Comment hidden (obsolete)
Comment 8 Build Bot 2013-08-25 09:51:32 PDT Comment hidden (obsolete)
Comment 9 Darin Adler 2019-06-30 20:07:51 PDT
Created attachment 373203 [details]
Patch
Comment 10 Darin Adler 2019-06-30 20:09:44 PDT
The new patch should not have the mistake from the one I posted about 6 years ago.
Comment 11 Darin Adler 2019-07-01 07:51:27 PDT
Since EWS is all green, adding some possible reviewers to the cc list.
Comment 12 Darin Adler 2019-07-01 09:41:51 PDT
I chose the names that start with "can" to match the style of existing functions, including the ones in SecurityOrigin. I also consider names that start with "may" and various other wording. Iā€™m open to suggestions for other naming schemes.
Comment 13 Alex Christensen 2019-07-01 13:53:00 PDT
Comment on attachment 373203 [details]
Patch

This looks like it's full of subtle changes.  Could we hold off on this and land it at a better time in our release cycle?  It's been waiting 6 years, what's a few more weeks?
Comment 14 Darin Adler 2019-07-01 16:54:12 PDT
(In reply to Alex Christensen from comment #13)
> This looks like it's full of subtle changes.  Could we hold off on this and
> land it at a better time in our release cycle?  It's been waiting 6 years,
> what's a few more weeks?

Yes, sure, reviewing this and landing this could wait a few more weeks, months, or even years.
Comment 15 Darin Adler 2019-07-01 17:02:07 PDT
I guess it would be best to review and land this soon after Apple makes the internal major release branches, which is weeks or months away.
Comment 16 Alex Christensen 2019-07-17 12:32:18 PDT
Comment on attachment 373203 [details]
Patch

Let's do this
Comment 17 WebKit Commit Bot 2019-07-17 13:02:43 PDT
Comment on attachment 373203 [details]
Patch

Clearing flags on attachment: 373203

Committed r247529: <https://trac.webkit.org/changeset/247529>
Comment 18 WebKit Commit Bot 2019-07-17 13:02:45 PDT
All reviewed patches have been landed.  Closing bug.
Comment 19 Radar WebKit Bug Importer 2019-07-17 13:03:21 PDT
<rdar://problem/53216964>