Bug 120265 - No need for clearTimers function in Frame
Summary: No need for clearTimers function in Frame
Status: RESOLVED WONTFIX
Alias: None
Product: WebKit
Classification: Unclassified
Component: Page Loading (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Darin Adler
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-25 01:25 PDT by Darin Adler
Modified: 2017-06-07 09:06 PDT (History)
3 users (show)

See Also:


Attachments
Patch (3.64 KB, patch)
2013-08-25 01:27 PDT, Darin Adler
no flags Details | Formatted Diff | Diff
Patch (4.37 KB, patch)
2014-02-02 22:15 PST, Darin Adler
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Darin Adler 2013-08-25 01:25:26 PDT
No need for clearTimers function in Frame
Comment 1 Darin Adler 2013-08-25 01:27:22 PDT
Created attachment 209577 [details]
Patch
Comment 2 Andreas Kling 2013-08-25 02:07:05 PDT
Comment on attachment 209577 [details]
Patch

Nice.
Comment 3 WebKit Commit Bot 2013-08-25 02:32:26 PDT
Comment on attachment 209577 [details]
Patch

Clearing flags on attachment: 209577

Committed r154571: <http://trac.webkit.org/changeset/154571>
Comment 4 WebKit Commit Bot 2013-08-25 02:32:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 David Kilzer (:ddkilzer) 2013-08-25 07:21:42 PDT
This broke the internal iOS build in Source/WebCore/page/ios/FrameIOS.mm.

Rolled out in r154577.  <http://trac.webkit.org/r154577>
Comment 6 Darin Adler 2013-08-25 10:18:23 PDT
Can we upstream the iOS code that depends on this?
Comment 7 Antonio Gomes 2013-08-26 04:47:28 PDT
(In reply to comment #5)
> This broke the internal iOS build in Source/WebCore/page/ios/FrameIOS.mm.
> 
> Rolled out in r154577.  <http://trac.webkit.org/r154577>

Hi.

Did you reopen it because Darin is an Apple employee and can supposedly easily build IOS private branch, or is it now WebKit developers' responsibility to maintain it?
Comment 8 Darin Adler 2014-02-02 22:15:09 PST
Created attachment 222961 [details]
Patch
Comment 9 Darin Adler 2014-02-02 22:15:58 PST
Oops, forgot about the problem with iOS.
Comment 10 Darin Adler 2017-06-07 09:06:45 PDT
I am not going to bother with this any time soon.