Bug 120256 - Simplify some more Settings access where we have a Frame in reach.
Summary: Simplify some more Settings access where we have a Frame in reach.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-24 16:27 PDT by Andreas Kling
Modified: 2013-08-27 08:41 PDT (History)
17 users (show)

See Also:

Attachments
Patch (9.61 KB, patch)
2013-08-24 16:46 PDT, Andreas Kling 		darin: review+
Details | Formatted Diff | Diff
Lander (9.80 KB, patch)
2013-08-24 16:53 PDT, Andreas Kling 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
Lander II: The Landening (10.00 KB, patch)
2013-08-24 17:52 PDT, Andreas Kling 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-24 16:27:03 PDT 
Simplify some more Settings access where we have a Frame in reach.
Comment 1 Andreas Kling 2013-08-24 16:46:47 PDT 
Created attachment 209562 [details]
Patch
Comment 2 Andreas Kling 2013-08-24 16:53:49 PDT 
Created attachment 209563 [details]
Lander
Comment 3 WebKit Commit Bot 2013-08-24 17:17:22 PDT 
Comment on attachment 209563 [details]
Lander

Rejecting attachment 209563 [details] from commit-queue.

Failed to run "['/Volumes/Data/EWS/WebKit/Tools/Scripts/webkit-patch', '--status-host=webkit-queues.appspot.com', '--bot-id=webkit-cq-01', 'build', '--no-clean', '--no-update', '--build-style=release', '--port=mac']" exit_code: 2 cwd: /Volumes/Data/EWS/WebKit

Last 500 characters of output:
Versions/A/WebCore
Undefined symbols for architecture x86_64:
  "__ZNK7WebCore12RenderObject5frameEv", referenced from:
      __ZN7WebCore17RenderSearchField15addSearchResultEv in RenderSearchField.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)


** BUILD FAILED **


The following build commands failed:
	Ld /Volumes/Data/EWS/WebKit/WebKitBuild/Release/WebCore.framework/Versions/A/WebCore normal x86_64
(1 failure)

Full output: http://webkit-queues.appspot.com/results/1543779
Comment 4 Andreas Kling 2013-08-24 17:52:01 PDT 
Created attachment 209565 [details]
Lander II: The Landening
Comment 5 Early Warning System Bot 2013-08-24 18:01:14 PDT 
Comment on attachment 209565 [details]
Lander II: The Landening

Attachment 209565 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1555695
Comment 6 Early Warning System Bot 2013-08-24 18:03:30 PDT 
Comment on attachment 209565 [details]
Lander II: The Landening

Attachment 209565 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1542755
Comment 7 EFL EWS Bot 2013-08-24 18:38:16 PDT 
Comment on attachment 209565 [details]
Lander II: The Landening

Attachment 209565 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1543803
Comment 8 EFL EWS Bot 2013-08-24 18:47:12 PDT 
Comment on attachment 209565 [details]
Lander II: The Landening

Attachment 209565 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1544764
Comment 9 Andreas Kling 2013-08-27 08:26:22 PDT 
Committed r154688: <http://trac.webkit.org/changeset/154688>
Comment 10 Csaba Osztrogonác 2013-08-27 08:41:15 PDT 
(In reply to comment #9)
> Committed r154688: <http://trac.webkit.org/changeset/154688>

Did you really commit intentionally against the red EWS bots and
broke the build everywhere? Congratulations! It was so friendly. :-/

I think you should read the contribution rules one more time:
http://www.webkit.org/coding/contributing.html

"Your change must at least compile on all platforms."

I can't see any "except Kling" for this rule ...