Bug 120251 - RenderObject::frame() should return a reference.
Summary: RenderObject::frame() should return a reference.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-24 11:03 PDT by Andreas Kling
Modified: 2013-08-24 15:49 PDT (History)
11 users (show)

See Also:

Attachments
EWS experiment (61.44 KB, patch)
2013-08-24 11:04 PDT, Andreas Kling 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
EWS experiment 2 (64.54 KB, patch)
2013-08-24 11:12 PDT, Andreas Kling 		gtk-ews: commit-queue-
Details | Formatted Diff | Diff
EWS experiment 3 (65.17 KB, patch)
2013-08-24 11:21 PDT, Andreas Kling 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
EWS experiment 4 (65.56 KB, patch)
2013-08-24 13:13 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
EWS experiment 4 (65.56 KB, patch)
2013-08-24 14:04 PDT, Andreas Kling 		webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Patch (66.41 KB, patch)
2013-08-24 15:00 PDT, Andreas Kling 		no flags Details | Formatted Diff | Diff
Show Obsolete (5) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-24 11:03:49 PDT 
We can always go RenderObject -> RenderView -> FrameView -> Frame.
Comment 1 Andreas Kling 2013-08-24 11:04:30 PDT 
Created attachment 209546 [details]
EWS experiment
Comment 2 Early Warning System Bot 2013-08-24 11:10:15 PDT 
Comment on attachment 209546 [details]
EWS experiment

Attachment 209546 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1528959
Comment 3 Andreas Kling 2013-08-24 11:12:16 PDT 
Created attachment 209547 [details]
EWS experiment 2
Comment 4 kov's GTK+ EWS bot 2013-08-24 11:18:08 PDT 
Comment on attachment 209547 [details]
EWS experiment 2

Attachment 209547 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1561280
Comment 5 Early Warning System Bot 2013-08-24 11:18:28 PDT 
Comment on attachment 209547 [details]
EWS experiment 2

Attachment 209547 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1555591
Comment 6 Andreas Kling 2013-08-24 11:21:21 PDT 
Created attachment 209550 [details]
EWS experiment 3
Comment 7 Early Warning System Bot 2013-08-24 11:28:58 PDT 
Comment on attachment 209550 [details]
EWS experiment 3

Attachment 209550 [details] did not pass qt-ews (qt):
Output: http://webkit-queues.appspot.com/results/1561284
Comment 8 Early Warning System Bot 2013-08-24 11:32:04 PDT 
Comment on attachment 209550 [details]
EWS experiment 3

Attachment 209550 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1562137
Comment 9 EFL EWS Bot 2013-08-24 11:43:40 PDT 
Comment on attachment 209550 [details]
EWS experiment 3

Attachment 209550 [details] did not pass efl-wk2-ews (efl-wk2):
Output: http://webkit-queues.appspot.com/results/1555606
Comment 10 Build Bot 2013-08-24 11:53:39 PDT 
Comment on attachment 209550 [details]
EWS experiment 3

Attachment 209550 [details] did not pass mac-wk2-ews (mac-wk2):
Output: http://webkit-queues.appspot.com/results/1557529
Comment 11 EFL EWS Bot 2013-08-24 11:56:02 PDT 
Comment on attachment 209550 [details]
EWS experiment 3

Attachment 209550 [details] did not pass efl-ews (efl):
Output: http://webkit-queues.appspot.com/results/1528968
Comment 12 Build Bot 2013-08-24 12:11:09 PDT 
Comment on attachment 209550 [details]
EWS experiment 3

Attachment 209550 [details] did not pass mac-ews (mac):
Output: http://webkit-queues.appspot.com/results/1543719
Comment 13 Andreas Kling 2013-08-24 13:13:29 PDT 
Created attachment 209554 [details]
EWS experiment 4
Comment 14 Andreas Kling 2013-08-24 14:04:25 PDT 
Created attachment 209558 [details]
EWS experiment 4

Reuploading since EWS was snorkled.
Comment 15 Early Warning System Bot 2013-08-24 14:25:50 PDT 
Comment on attachment 209558 [details]
EWS experiment 4

Attachment 209558 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1560390
Comment 16 Andreas Kling 2013-08-24 15:00:52 PDT 
Created attachment 209559 [details]
Patch
Comment 17 Darin Adler 2013-08-24 15:17:23 PDT 
Comment on attachment 209559 [details]
Patch

Those local variables of type Frame& worry me a little because they don’t ref the frame. But Frame* was just as bad. We might have to add RefRef!
Comment 18 Andreas Kling 2013-08-24 15:21:11 PDT 
(In reply to comment #17)
> (From update of attachment 209559 [details])
> Those local variables of type Frame& worry me a little because they don’t ref the frame. But Frame* was just as bad. We might have to add RefRef!

RefRef! Maybe just Ref?
Could be more efficient than RefPtr since it doesn't need to null check before calling ref()/deref().
Comment 19 WebKit Commit Bot 2013-08-24 15:49:44 PDT 
Comment on attachment 209559 [details]
Patch

Clearing flags on attachment: 209559

Committed r154554: <http://trac.webkit.org/changeset/154554>
Comment 20 WebKit Commit Bot 2013-08-24 15:49:47 PDT 
All reviewed patches have been landed.  Closing bug.