RESOLVED FIXED 120251
RenderObject::frame() should return a reference. 
https://bugs.webkit.org/show_bug.cgi?id=120251
Summary RenderObject::frame() should return a reference.
Andreas Kling
Reported 2013-08-24 11:03:49 PDT
We can always go RenderObject -> RenderView -> FrameView -> Frame.
Attachments
EWS experiment (61.44 KB, patch)
2013-08-24 11:04 PDT, Andreas Kling 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
EWS experiment 2 (64.54 KB, patch)
2013-08-24 11:12 PDT, Andreas Kling 		gtk-ews: commit-queue-
DetailsFormatted DiffDiff
EWS experiment 3 (65.17 KB, patch)
2013-08-24 11:21 PDT, Andreas Kling 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
EWS experiment 4 (65.56 KB, patch)
2013-08-24 13:13 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
EWS experiment 4 (65.56 KB, patch)
2013-08-24 14:04 PDT, Andreas Kling 		webkit-ews: commit-queue-
DetailsFormatted DiffDiff
Patch (66.41 KB, patch)
2013-08-24 15:00 PDT, Andreas Kling 		no flags
DetailsFormatted DiffDiff
Show Obsolete (5) View All Add attachment proposed patch, testcase, etc.
Andreas Kling
Comment 1 2013-08-24 11:04:30 PDT
Created attachment 209546 [details] EWS experiment
Early Warning System Bot
Comment 2 2013-08-24 11:10:15 PDT
Comment on attachment 209546 [details] EWS experiment Attachment 209546 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1528959
Andreas Kling
Comment 3 2013-08-24 11:12:16 PDT
Created attachment 209547 [details] EWS experiment 2
kov's GTK+ EWS bot
Comment 4 2013-08-24 11:18:08 PDT
Comment on attachment 209547 [details] EWS experiment 2 Attachment 209547 [details] did not pass gtk-ews (gtk): Output: http://webkit-queues.appspot.com/results/1561280
Early Warning System Bot
Comment 5 2013-08-24 11:18:28 PDT
Comment on attachment 209547 [details] EWS experiment 2 Attachment 209547 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1555591
Andreas Kling
Comment 6 2013-08-24 11:21:21 PDT
Created attachment 209550 [details] EWS experiment 3
Early Warning System Bot
Comment 7 2013-08-24 11:28:58 PDT
Comment on attachment 209550 [details] EWS experiment 3 Attachment 209550 [details] did not pass qt-ews (qt): Output: http://webkit-queues.appspot.com/results/1561284
Early Warning System Bot
Comment 8 2013-08-24 11:32:04 PDT
Comment on attachment 209550 [details] EWS experiment 3 Attachment 209550 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1562137
EFL EWS Bot
Comment 9 2013-08-24 11:43:40 PDT
Comment on attachment 209550 [details] EWS experiment 3 Attachment 209550 [details] did not pass efl-wk2-ews (efl-wk2): Output: http://webkit-queues.appspot.com/results/1555606
Build Bot
Comment 10 2013-08-24 11:53:39 PDT
Comment on attachment 209550 [details] EWS experiment 3 Attachment 209550 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1557529
EFL EWS Bot
Comment 11 2013-08-24 11:56:02 PDT
Comment on attachment 209550 [details] EWS experiment 3 Attachment 209550 [details] did not pass efl-ews (efl): Output: http://webkit-queues.appspot.com/results/1528968
Build Bot
Comment 12 2013-08-24 12:11:09 PDT
Comment on attachment 209550 [details] EWS experiment 3 Attachment 209550 [details] did not pass mac-ews (mac): Output: http://webkit-queues.appspot.com/results/1543719
Andreas Kling
Comment 13 2013-08-24 13:13:29 PDT
Created attachment 209554 [details] EWS experiment 4
Andreas Kling
Comment 14 2013-08-24 14:04:25 PDT
Created attachment 209558 [details] EWS experiment 4 Reuploading since EWS was snorkled.
Early Warning System Bot
Comment 15 2013-08-24 14:25:50 PDT
Comment on attachment 209558 [details] EWS experiment 4 Attachment 209558 [details] did not pass qt-wk2-ews (qt-wk2): Output: http://webkit-queues.appspot.com/results/1560390
Andreas Kling
Comment 16 2013-08-24 15:00:52 PDT
Created attachment 209559 [details] Patch
Darin Adler
Comment 17 2013-08-24 15:17:23 PDT
Comment on attachment 209559 [details] Patch Those local variables of type Frame& worry me a little because they don’t ref the frame. But Frame* was just as bad. We might have to add RefRef!
Andreas Kling
Comment 18 2013-08-24 15:21:11 PDT
(In reply to comment #17) > (From update of attachment 209559 [details]) > Those local variables of type Frame& worry me a little because they don’t ref the frame. But Frame* was just as bad. We might have to add RefRef! RefRef! Maybe just Ref? Could be more efficient than RefPtr since it doesn't need to null check before calling ref()/deref().
WebKit Commit Bot
Comment 19 2013-08-24 15:49:44 PDT
Comment on attachment 209559 [details] Patch Clearing flags on attachment: 209559 Committed r154554: <http://trac.webkit.org/changeset/154554>
WebKit Commit Bot
Comment 20 2013-08-24 15:49:47 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.