WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
120242
Web Inspector: We should regenerate InspectorBackendCommands.js for Legacy Inspector.json versions
https://bugs.webkit.org/show_bug.cgi?id=120242
Summary
Web Inspector: We should regenerate InspectorBackendCommands.js for Legacy In...
Joseph Pecoraro
Reported
2013-08-23 17:52:02 PDT
Older Inspector.json files could benefit from the enum values, which is just new sugar generated from the Inspector.json that existed. We should regenerate the InspectorBackendCommands.js for older, fixed versions. And we should include the older Inspector.json files so that we can easily compare against this. For starters, this should happen with iOS 6's Legacy/6.0/InspectorBackendCommands.js.
Attachments
[PATCH] Proposed Fix
(174.55 KB, patch)
2013-08-23 17:58 PDT
,
Joseph Pecoraro
timothy
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1
2013-08-23 17:52:49 PDT
<
rdar://problem/14825561
>
Joseph Pecoraro
Comment 2
2013-08-23 17:58:05 PDT
Created
attachment 209528
[details]
[PATCH] Proposed Fix - includes the Inspector.json for iOS 6.0. - includes a script for regenerating the Legacy/6.0/InspectorBackendCommands.js. - some other tweaks to improve output
Joseph Pecoraro
Comment 3
2013-08-23 18:08:21 PDT
FWIW, iOS 6.1 was identical to iOS 6.0.
Timothy Hatcher
Comment 4
2013-08-24 08:10:26 PDT
Comment on
attachment 209528
[details]
[PATCH] Proposed Fix View in context:
https://bugs.webkit.org/attachment.cgi?id=209528&action=review
> Source/WebInspectorUI/ChangeLog:9 > + - Provide a helper script to regenerate the backend commands file for trunk and Versions.
We should run this every build eventually. Maybe we should disable the JS command generation in WebCore.
Joseph Pecoraro
Comment 5
2013-08-26 13:38:17 PDT
(In reply to
comment #4
)
> (From update of
attachment 209528
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=209528&action=review
> > > Source/WebInspectorUI/ChangeLog:9 > > + - Provide a helper script to regenerate the backend commands file for trunk and Versions. > > We should run this every build eventually. Maybe we should disable the JS command generation in WebCore.
Good idea. I'd love to do that once we've had all clients switch to the new inspector frontend! It is pretty fast, and if we could make a few changes to only generate the JS file for older inputs.
Joseph Pecoraro
Comment 6
2013-08-26 16:39:01 PDT
Committed <
http://trac.webkit.org/changeset/154651
>. Sorry for landing with "OOPs" in the commit message. It did have a reviewer in the ChangeLogs!
Brian Burg
Comment 7
2013-09-30 13:27:50 PDT
***
Bug 117843
has been marked as a duplicate of this bug. ***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug