WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
120233
Let Document keep its RenderView during render tree detach.
https://bugs.webkit.org/show_bug.cgi?id=120233
Summary
Let Document keep its RenderView during render tree detach.
Andreas Kling
Reported
2013-08-23 14:02:29 PDT
Let Document keep its RenderView during render tree detach.
Attachments
Patch
(1.61 KB, patch)
2013-08-23 14:04 PDT
,
Andreas Kling
koivisto
: review-
Details
Formatted Diff
Diff
Patch v2
(3.46 KB, patch)
2013-08-24 04:07 PDT
,
Andreas Kling
koivisto
: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Andreas Kling
Comment 1
2013-08-23 14:04:44 PDT
Created
attachment 209509
[details]
Patch
Antti Koivisto
Comment 2
2013-08-23 14:12:21 PDT
Comment on
attachment 209509
[details]
Patch Search for documentBeingDestroyed()
Andreas Kling
Comment 3
2013-08-24 04:07:07 PDT
Created
attachment 209539
[details]
Patch v2 Okay, give Document a flag for "render tree being ripped out LOL" mode.
Antti Koivisto
Comment 4
2013-08-24 04:10:21 PDT
Comment on
attachment 209539
[details]
Patch v2 View in context:
https://bugs.webkit.org/attachment.cgi?id=209539&action=review
> Source/WebCore/dom/Document.cpp:2038 > + m_renderTreeBeingDestroyed = true;
maybe TemporaryChange<bool>?
Andreas Kling
Comment 5
2013-08-24 04:20:30 PDT
Committed
r154542
: <
http://trac.webkit.org/changeset/154542
>
Darin Adler
Comment 6
2013-08-24 15:12:45 PDT
Comment on
attachment 209539
[details]
Patch v2 View in context:
https://bugs.webkit.org/attachment.cgi?id=209539&action=review
> Source/WebCore/dom/Document.cpp:483 > + , m_renderTreeBeingDestroyed(false)
I would call this m_isDestroyingRenderTree as in “document is destroying render tree”.
> Source/WebCore/dom/Document.h:550 > + bool renderTreeBeingDestroyed() const { return m_renderTreeBeingDestroyed; }
I would call this isDestroyingRenderTree() as in “document is destroying render tree”.
Andreas Kling
Comment 7
2013-08-24 15:14:01 PDT
(In reply to
comment #6
)
> (From update of
attachment 209539
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=209539&action=review
> > > Source/WebCore/dom/Document.cpp:483 > > + , m_renderTreeBeingDestroyed(false) > > I would call this m_isDestroyingRenderTree as in “document is destroying render tree”. > > > Source/WebCore/dom/Document.h:550 > > + bool renderTreeBeingDestroyed() const { return m_renderTreeBeingDestroyed; } > > I would call this isDestroyingRenderTree() as in “document is destroying render tree”.
Yeah, in retrospect that is a better name. isDetachingRenderTree() is another alternative.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug