Bug 120226 – Use ElementTraversal some more

• Status: RESOLVED
• Resolution: FIXED
• Component: DOM

[Antti Koivisto]

In random places.

[Antti Koivisto]

Created attachment 209505 [details]
patch

[Darin Adler]

Comment on attachment 209505 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209505&action=review

> Source/WebCore/accessibility/AccessibilityNodeObject.cpp:1126
> +        const AtomicString& siblingAriaRole = sibling->getAttribute(roleAttr);

Could be fastGetAttribute.

> Source/WebCore/html/HTMLObjectElement.cpp:464
> -    for (Element* child = ElementTraversal::firstWithin(this); child; child = ElementTraversal::nextSibling(child)) {
> +    for (auto child = ElementTraversal::firstChild(this); child; child = ElementTraversal::nextSibling(child)) {

Looks to me like this is a drive-by bug fix. Was something slightly broken?

[Antti Koivisto]

(In reply to comment #2)
> Looks to me like this is a drive-by bug fix. Was something slightly broken?

No. For Elements firstWithin and firstChild are always the same (Element's parent is always Element or the root). However it is semantically better to pair firstChild with nextSibling and firstWithin with next (it obviously matters for more specific element types).

[Antti Koivisto]

http://trac.webkit.org/changeset/154525