Bug 120213 - Text nodes should also return text when asked for it
Summary: Text nodes should also return text when asked for it
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-23 11:03 PDT by Roger Fong
Modified: 2013-10-30 10:23 PDT (History)
3 users (show)

See Also:

Attachments
patch (1.05 KB, patch)
2013-08-23 11:12 PDT, Roger Fong 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Roger Fong 2013-08-23 11:03:10 PDT 
Nodes shouldn't have to be element nodes to return text.
Just text nodes by themselves should be able to return text as well when queried for it.

Without this, static text doesn't return text when asked via accessibility api.
Comment 1 Radar WebKit Bug Importer 2013-08-23 11:03:25 PDT 
<rdar://problem/14820810>
Comment 2 Roger Fong 2013-08-23 11:12:54 PDT 
Created attachment 209476 [details]
patch
Comment 3 chris fleizach 2013-08-23 11:13:55 PDT 
Comment on attachment 209476 [details]
patch

We need a test case, but otherwise this looks right. Thanks
Comment 4 Roger Fong 2013-08-23 12:40:08 PDT 
In my attempt to look for a proper way to create a test I found another method alongside text(), stringValue(), which does what I want I need and gets the underlying string value for the text node.

I will use that in my AccessibleText implementation instead so as to not risk breaking any existing tests on other platforms.

Moving changes for Windows stuff out of WebCore, always good.
Comment 5 Brent Fulgham 2013-10-30 10:23:57 PDT 
Comment on attachment 209476 [details]
patch

Clearing flag to remove from review queue.