Bug 120204 - Tighten before/after pseudo element accessors
Summary: Tighten before/after pseudo element accessors
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-23 04:19 PDT by Antti Koivisto
Modified: 2013-08-24 04:15 PDT (History)
11 users (show)

See Also:

Attachments
patch (24.10 KB, patch)
2013-08-23 04:33 PDT, Antti Koivisto 		gtk-ews: commit-queue-
Details | Formatted Diff | Diff
another (24.39 KB, patch)
2013-08-24 00:14 PDT, Antti Koivisto 		kling: review+
gtk-ews: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-08-23 04:19:57 PDT 
We have generic looking Element::pseudoElement(PseudoID) which only returns before/after pseudo elements.
Comment 1 Antti Koivisto 2013-08-23 04:33:13 PDT 
Created attachment 209448 [details]
patch
Comment 2 kov's GTK+ EWS bot 2013-08-23 05:34:33 PDT 
Comment on attachment 209448 [details]
patch

Attachment 209448 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1528576
Comment 3 Antti Koivisto 2013-08-24 00:14:10 PDT 
Created attachment 209534 [details]
another
Comment 4 kov's GTK+ EWS bot 2013-08-24 01:27:48 PDT 
Comment on attachment 209534 [details]
another

Attachment 209534 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1529786
Comment 5 kov's GTK+ EWS bot 2013-08-24 02:46:59 PDT 
Comment on attachment 209534 [details]
another

Attachment 209534 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1557420
Comment 6 Andreas Kling 2013-08-24 03:51:28 PDT 
Comment on attachment 209534 [details]
another

View in context: https://bugs.webkit.org/attachment.cgi?id=209534&action=review

r=me

> Source/WebCore/dom/Element.cpp:2069
> +    if (pseudoElementSpecifier != BEFORE && pseudoElementSpecifier != AFTER)
> +        return 0;
> +    return pseudoElementSpecifier == BEFORE ? host->beforePseudoElement() : host->afterPseudoElement();

This might look better as a switch.

> Source/WebCore/dom/Element.cpp:2310
> +bool Element::updateExistingPseudoElement(PseudoElement* existing, Style::Change change)

existing -> existingPseudoElement?

> Source/WebCore/dom/Element.cpp:2341
> +    if (PseudoElement* existing = beforePseudoElement()) {

existing -> existingPseudoElement?

> Source/WebCore/dom/Element.cpp:2352
> +    if (PseudoElement* existing = afterPseudoElement()) {

existing -> existingPseudoElement?

> Source/WebCore/dom/Element.cpp:2396
> +    if (!hasRareData())
> +        return;

This could be an assertion instead, if we moved the two clearFooPseudoElement() calls in clearStyleDerived... after the hasRareData check.

> Source/WebCore/dom/Element.cpp:2404
> +    if (!hasRareData())
> +        return;

Ditto.
Comment 7 Antti Koivisto 2013-08-24 04:15:11 PDT 
https://trac.webkit.org/r154541