Bug 120181 – regexp-match-reify-before-putbyval is not a JSRegress test

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[Mark Hahnenberg]

It uses stuff that's not available when using run-jsc-benchmarks and it's not a performance test, which is what JSRegress is for (JS performance regression tests). Admittedly it's not well named, but I digress.

[Michael Saboff]

Created attachment 209483 [details]
Patch

[Mark Hahnenberg]

Comment on attachment 209483 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209483&action=review

r=me

> LayoutTests/fast/js/regexp-match-reify-before-putbyval-expected.txt:4
> -JSRegress/regexp-match-reify-before-putbyval
> -
> -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
> -
> -
>  PASS matches is ['http://www.dummy.com/images/123x456/image.jpg','http://www.dummy.com/images/',111,'x',222,'/image.jpg']
> -PASS no exception thrown
>  PASS successfullyParsed is true
>  
>  TEST COMPLETE

I'm confused...how are there two of the same file?

[Geoffrey Garen]

Comment on attachment 209483 [details]
Patch

r=me

[Mark Hahnenberg]

(In reply to comment #2)
> (From update of attachment 209483 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=209483&action=review
> 
> r=me
> 
> > LayoutTests/fast/js/regexp-match-reify-before-putbyval-expected.txt:4
> > -JSRegress/regexp-match-reify-before-putbyval
> > -
> > -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
> > -
> > -
> >  PASS matches is ['http://www.dummy.com/images/123x456/image.jpg','http://www.dummy.com/images/',111,'x',222,'/image.jpg']
> > -PASS no exception thrown
> >  PASS successfullyParsed is true
> >  
> >  TEST COMPLETE
> 
> I'm confused...how are there two of the same file?

Ahh svn, you're a mystery wrapped in an enigma.

[Michael Saboff]

(In reply to comment #2)
> (From update of attachment 209483 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=209483&action=review
> 
> r=me
> 
> > LayoutTests/fast/js/regexp-match-reify-before-putbyval-expected.txt:4
> > -JSRegress/regexp-match-reify-before-putbyval
> > -
> > -On success, you will see a series of "PASS" messages, followed by "TEST COMPLETE".
> > -
> > -
> >  PASS matches is ['http://www.dummy.com/images/123x456/image.jpg','http://www.dummy.com/images/',111,'x',222,'/image.jpg']
> > -PASS no exception thrown
> >  PASS successfullyParsed is true
> >  
> >  TEST COMPLETE
> 
> I'm confused...how are there two of the same file?

Because there is a move then a change.

[WebKit Commit Bot]

Comment on attachment 209483 [details]
Patch

Clearing flags on attachment: 209483

Committed r154506: <http://trac.webkit.org/changeset/154506>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.