Bug 120174 - Don't leak registers for redeclared variables
Summary: Don't leak registers for redeclared variables
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-22 15:00 PDT by Gavin Barraclough
Modified: 2013-08-23 10:50 PDT (History)
1 user (show)

See Also:

Attachments
Fix (3.44 KB, patch)
2013-08-22 15:02 PDT, Gavin Barraclough 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2013-08-22 15:00:31 PDT 
We currently always allocate registers for new global variables, but these are wasted when the variable is being redeclared.
Only allocate new registers when necessary.
Comment 1 Gavin Barraclough 2013-08-22 15:02:25 PDT 
Created attachment 209397 [details]
Fix
Comment 2 Gavin Barraclough 2013-08-22 15:40:57 PDT 
Comment on attachment 209397 [details]
Fix

Ooops, self r+!
Comment 3 Geoffrey Garen 2013-08-22 16:02:12 PDT 
Comment on attachment 209397 [details]
Fix

r=me
Comment 4 Gavin Barraclough 2013-08-23 10:50:14 PDT 
Committed revision 154466.