Bug 120145 - Another null-deref under WebDragClient::startDrag
Summary: Another null-deref under WebDragClient::startDrag
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
Keywords: InRadar
Depends on:
Reported: 2013-08-21 17:54 PDT by Tim Horton
Modified: 2013-08-21 17:59 PDT (History)
3 users (show)

See Also:

patch (1.50 KB, patch)
2013-08-21 17:55 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-08-21 17:54:18 PDT
In http://trac.webkit.org/changeset/153511 I made convertImageToBitmap return null instead of dereferencing the null ShareableBitmap, but missed the place where we dereference the return value, and I missed that because I simultaneously fixed the one reproducible case of getting a null into this method in the first place :(

Add the second null-deref.

Comment 1 Tim Horton 2013-08-21 17:55:51 PDT
Created attachment 209316 [details]
Comment 2 Tim Horton 2013-08-21 17:59:08 PDT