WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
120137
Win64 build needs more PlatformArchitecture macro usage
https://bugs.webkit.org/show_bug.cgi?id=120137
Summary
Win64 build needs more PlatformArchitecture macro usage
Alex Christensen
Reported
2013-08-21 13:54:41 PDT
I replaced more lib32/bin32/obj32 with the PlatformArchitecture macro/environment variable and it works for a complete 64-bit build of WinCairo without breaking anything, and it's a huge step in the right direction for the AppleWin port. I had to export PlatformArchitecture to get it to work with the makefiles, which pass it to the bash scripts as a command line parameter.
Attachments
Patch
(25.46 KB, patch)
2013-08-21 14:17 PDT
,
Alex Christensen
bfulgham
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Alex Christensen
Comment 1
2013-08-21 14:17:22 PDT
Created
attachment 209303
[details]
Patch
Brent Fulgham
Comment 2
2013-08-21 14:20:28 PDT
Comment on
attachment 209303
[details]
Patch r=me
Alex Christensen
Comment 3
2013-08-21 14:24:42 PDT
r154416
WebKit Commit Bot
Comment 4
2013-08-21 21:35:47 PDT
Re-opened since this is blocked by
bug 120147
Brent Fulgham
Comment 5
2013-10-09 09:43:09 PDT
Re-closing. These changes were landed in a follow-up issue to
Bug 120147
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug