Bug 120137 - Win64 build needs more PlatformArchitecture macro usage
Summary: Win64 build needs more PlatformArchitecture macro usage
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Nobody
Depends on: 120147
  Show dependency treegraph
Reported: 2013-08-21 13:54 PDT by Alex Christensen
Modified: 2013-10-09 09:43 PDT (History)
2 users (show)

See Also:

Patch (25.46 KB, patch)
2013-08-21 14:17 PDT, Alex Christensen
bfulgham: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Christensen 2013-08-21 13:54:41 PDT
I replaced more lib32/bin32/obj32 with the PlatformArchitecture macro/environment variable and it works for a complete 64-bit build of WinCairo without breaking anything, and it's a huge step in the right direction for the AppleWin port.  I had to export PlatformArchitecture to get it to work with the makefiles, which pass it to the bash scripts as a command line parameter.
Comment 1 Alex Christensen 2013-08-21 14:17:22 PDT
Created attachment 209303 [details]
Comment 2 Brent Fulgham 2013-08-21 14:20:28 PDT
Comment on attachment 209303 [details]

Comment 3 Alex Christensen 2013-08-21 14:24:42 PDT
Comment 4 WebKit Commit Bot 2013-08-21 21:35:47 PDT
Re-opened since this is blocked by bug 120147
Comment 5 Brent Fulgham 2013-10-09 09:43:09 PDT
Re-closing. These changes were landed in a follow-up issue to Bug 120147.