Bug 120134 – [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Joseph Pecoraro]

Patch to follow.

# Before Change
(lldb) command script import /Volumes/Data/Code/webkit-open-source/Tools/lldb/lldb_webkit.py
(lldb) p mimeType
(const WTF::String) $9 = { length = 16, contents = '\u6d69\u6761\u2f65\u6e70\u3b67\u6162\u6573\u3436\u22a9\u22bd\u07ff\ud000\u211b\u22bd\u07ff\u8000' } {
  m_impl = {
    m_ptr = 0x00007ff22168bad0 { length = 16, is8bit = 0, contents = '\u6d69\u6761\u2f65\u6e70\u3b67\u6162\u6573\u3436\u22a9\u22bd\u07ff\ud000\u211b\u22bd\u07ff\u8000' }
  }
}

(lldb) p mimeType.is8Bit()
(bool) $10 = true

# After Change
(lldb) command script import /Volumes/Data/Code/webkit-open-source/Tools/lldb/lldb_webkit.py
(lldb) p mimeType
(const WTF::String) $11 = { length = 16, contents = 'image/png;base64' } {
  m_impl = {
    m_ptr = 0x00007ff22168bad0 { length = 16, is8bit = 1, contents = 'image/png;base64' }
  }
}

[Joseph Pecoraro]

Created attachment 209298 [details]
[PATCH] Proposed Fix

[WebKit Commit Bot]

Comment on attachment 209298 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 209298

Committed r154411: <http://trac.webkit.org/changeset/154411>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.