Bug 120134 - [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings
Summary: [Tools] lldb_webkit.py helpers is incorrectly printing 8bit Strings
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-21 13:27 PDT by Joseph Pecoraro
Modified: 2013-08-21 13:59 PDT (History)
4 users (show)

See Also:

Attachments
[PATCH] Proposed Fix (1.04 KB, patch)
2013-08-21 13:28 PDT, Joseph Pecoraro 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Joseph Pecoraro 2013-08-21 13:27:24 PDT 
Patch to follow.

# Before Change
(lldb) command script import /Volumes/Data/Code/webkit-open-source/Tools/lldb/lldb_webkit.py
(lldb) p mimeType
(const WTF::String) $9 = { length = 16, contents = '\u6d69\u6761\u2f65\u6e70\u3b67\u6162\u6573\u3436\u22a9\u22bd\u07ff\ud000\u211b\u22bd\u07ff\u8000' } {
  m_impl = {
    m_ptr = 0x00007ff22168bad0 { length = 16, is8bit = 0, contents = '\u6d69\u6761\u2f65\u6e70\u3b67\u6162\u6573\u3436\u22a9\u22bd\u07ff\ud000\u211b\u22bd\u07ff\u8000' }
  }
}

(lldb) p mimeType.is8Bit()
(bool) $10 = true

# After Change
(lldb) command script import /Volumes/Data/Code/webkit-open-source/Tools/lldb/lldb_webkit.py
(lldb) p mimeType
(const WTF::String) $11 = { length = 16, contents = 'image/png;base64' } {
  m_impl = {
    m_ptr = 0x00007ff22168bad0 { length = 16, is8bit = 1, contents = 'image/png;base64' }
  }
}
Comment 1 Joseph Pecoraro 2013-08-21 13:28:58 PDT 
Created attachment 209298 [details]
[PATCH] Proposed Fix
Comment 2 WebKit Commit Bot 2013-08-21 13:59:46 PDT 
Comment on attachment 209298 [details]
[PATCH] Proposed Fix

Clearing flags on attachment: 209298

Committed r154411: <http://trac.webkit.org/changeset/154411>
Comment 3 WebKit Commit Bot 2013-08-21 13:59:47 PDT 
All reviewed patches have been landed.  Closing bug.