Bug 120133 - Remove support for the hspace/vspace attributes on table
Summary: Remove support for the hspace/vspace attributes on table
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tables (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ahmad Saleem
URL:
Keywords: BrowserCompat, InRadar
: 167612 (view as bug list)
Depends on:
Blocks:
 
Reported: 2013-08-21 13:23 PDT by Simon Pieters (:zcorpan)
Modified: 2022-08-25 12:33 PDT (History)
13 users (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Simon Pieters (:zcorpan) 2013-08-21 13:23:29 PDT
WebKit supports vspace and hspace attributes on <table> while IE doesn't and Gecko only does in quirks mode and they are considering dropping that, too.

See https://bugzilla.mozilla.org/show_bug.cgi?id=725646

Compatibility analysis in https://bugzilla.mozilla.org/show_bug.cgi?id=725646#c14 and #c15 (summary: 4 out of top 53,000 sites' front pages have minor visual difference if vspace/hspace on table is dropped)

Chromium bug: https://code.google.com/p/chromium/issues/detail?id=277080
Comment 1 Ryosuke Niwa 2017-01-30 15:53:35 PST
*** Bug 167612 has been marked as a duplicate of this bug. ***
Comment 2 Ryosuke Niwa 2017-01-30 15:54:01 PST
See https://github.com/whatwg/html/pull/13
Comment 3 Ahmad Saleem 2022-08-18 12:05:14 PDT
Webkit still support 'hspace' and 'vspace':

https://github.com/WebKit/WebKit/blob/147df77f6bb805a2c35456b30b5bbb8f794b043c/Source/WebCore/html/HTMLTableElement.cpp#L330

Chrome / Blink removed it in 2015:

https://src.chromium.org/viewvc/blink?view=revision&revision=190025

Safari also fail following WPT tests:

https://wpt.fyi/results/html/rendering/non-replaced-elements/tables?label=master&label=experimental&aligned&view=subtest&q=table-vspace-hspace

Also Safari 15.6.1 on macOS 12.5.1 render this test case (from Chrome bug - Comment 9) different compared to Chrome Canary 106 and Firefox Nightly 105:

http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=2984

Just wanted to share updated test results. Thanks!
Comment 4 Ahmad Saleem 2022-08-22 23:46:06 PDT
I will work on it later tonight.
Comment 5 Ahmad Saleem 2022-08-23 04:19:24 PDT
https://github.com/WebKit/WebKit/pull/3573
Comment 6 EWS 2022-08-25 12:32:34 PDT
Committed 253788@main (6676a3759ed3): <https://commits.webkit.org/253788@main>

Reviewed commits have been landed. Closing PR #3631 and removing active labels.
Comment 7 Radar WebKit Bug Importer 2022-08-25 12:33:21 PDT
<rdar://problem/99150785>