Bug 120127 - Remove JSObject::propertyIsEnumerable
Summary: Remove JSObject::propertyIsEnumerable
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
Depends on:
Reported: 2013-08-21 11:50 PDT by Gavin Barraclough
Modified: 2013-08-21 12:50 PDT (History)
0 users

See Also:

Fix (3.49 KB, patch)
2013-08-21 11:52 PDT, Gavin Barraclough
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2013-08-21 11:50:34 PDT
This method just a wart.  Unnecessary const-casting, unnecessary function call, and less code if we remove.
Comment 1 Gavin Barraclough 2013-08-21 11:52:48 PDT
Created attachment 209290 [details]
Comment 2 Sam Weinig 2013-08-21 12:01:45 PDT
Comment on attachment 209290 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=209290&action=review

> Source/JavaScriptCore/ChangeLog:8
> +        This method just a wart.

This sentence just a wart.

> Source/JavaScriptCore/ChangeLog:9
> +        Unnecessary const-casting, unnecessary function call, and less code if we remove.

This sentence would be less words if we remove.

> Source/JavaScriptCore/runtime/ObjectPrototype.cpp:188
> +    PropertyDescriptor descriptor;
> +    bool enumerable = thisObject->getOwnPropertyDescriptor(exec, propertyName, descriptor) && descriptor.enumerable();
> +    return JSValue::encode(jsBoolean(enumerable));

This should should have a FIXME saying to use getOwnPropertySlot when it no longer has the global object hack.
Comment 3 Gavin Barraclough 2013-08-21 12:50:15 PDT
Committed revision 154405.