RESOLVED FIXED 120127
Remove JSObject::propertyIsEnumerable 
https://bugs.webkit.org/show_bug.cgi?id=120127
Summary Remove JSObject::propertyIsEnumerable
Gavin Barraclough
Reported 2013-08-21 11:50:34 PDT
This method just a wart. Unnecessary const-casting, unnecessary function call, and less code if we remove.
Attachments
Fix (3.49 KB, patch)
2013-08-21 11:52 PDT, Gavin Barraclough 		sam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gavin Barraclough
Comment 1 2013-08-21 11:52:48 PDT
Created attachment 209290 [details] Fix
Sam Weinig
Comment 2 2013-08-21 12:01:45 PDT
Comment on attachment 209290 [details] Fix View in context: https://bugs.webkit.org/attachment.cgi?id=209290&action=review > Source/JavaScriptCore/ChangeLog:8 > + This method just a wart. This sentence just a wart. > Source/JavaScriptCore/ChangeLog:9 > + Unnecessary const-casting, unnecessary function call, and less code if we remove. This sentence would be less words if we remove. > Source/JavaScriptCore/runtime/ObjectPrototype.cpp:188 > + PropertyDescriptor descriptor; > + bool enumerable = thisObject->getOwnPropertyDescriptor(exec, propertyName, descriptor) && descriptor.enumerable(); > + return JSValue::encode(jsBoolean(enumerable)); This should should have a FIXME saying to use getOwnPropertySlot when it no longer has the global object hack.
Gavin Barraclough
Comment 3 2013-08-21 12:50:15 PDT
Committed revision 154405.
Note You need to log in before you can comment on or make changes to this bug.