Bug 120118 - Frame::animation() should return a reference.
Summary: Frame::animation() should return a reference.
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Andreas Kling
Depends on:
Reported: 2013-08-21 10:00 PDT by Andreas Kling
Modified: 2013-08-21 11:59 PDT (History)
2 users (show)

See Also:

Patch (26.04 KB, patch)
2013-08-21 10:01 PDT, Andreas Kling
andersca: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Kling 2013-08-21 10:00:11 PDT
Frame::animation() should return a reference.
Comment 1 Andreas Kling 2013-08-21 10:01:00 PDT
Created attachment 209281 [details]
Comment 2 WebKit Commit Bot 2013-08-21 10:03:42 PDT
Attachment 209281 [details] did not pass style-queue:

Failed to run "['Tools/Scripts/check-webkit-style', '--diff-files', u'Source/WebCore/ChangeLog', u'Source/WebCore/css/CSSComputedStyleDeclaration.cpp', u'Source/WebCore/dom/Document.cpp', u'Source/WebCore/history/CachedFrame.cpp', u'Source/WebCore/page/Frame.cpp', u'Source/WebCore/page/Frame.h', u'Source/WebCore/page/FrameView.cpp', u'Source/WebCore/page/Page.cpp', u'Source/WebCore/page/animation/AnimationController.cpp', u'Source/WebCore/rendering/RenderLayer.cpp', u'Source/WebCore/rendering/RenderLayerBacking.cpp', u'Source/WebCore/rendering/RenderLayerCompositor.cpp', u'Source/WebCore/rendering/RenderObject.cpp', u'Source/WebCore/rendering/RenderObject.h', u'Source/WebCore/testing/Internals.cpp', u'Source/WebKit/blackberry/Api/WebPage.cpp', u'Source/WebKit/mac/WebView/WebView.mm', u'Source/WebKit/win/WebFrame.cpp']" exit_code: 1
Source/WebCore/rendering/RenderLayerCompositor.cpp:2185:  When wrapping a line, only indent 4 spaces.  [whitespace/indent] [3]
Total errors found: 1 in 18 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Andreas Kling 2013-08-21 11:59:50 PDT
Committed r154401: <http://trac.webkit.org/changeset/154401>