Even though we don't have a lot of cases where the Windows ports need High DPI support, we need to at least be able to parse the -webkit-image-set markup and act appropriately. This is also important to getting proper behavior in the new Web Inspector. This will become more important as more Windows devices are released with High DPI screens. This patch activates the CSS_IMAGE_SET macro so that we properly handle these CSS features.
<rdar://problem/14796262>
Created attachment 209271 [details] Patch
Created attachment 209272 [details] Patch 1 of 3 (Build Settings)
Comment on attachment 209272 [details] Patch 1 of 3 (Build Settings) I don't know why this file was improperly added to the archive. It's just a text file.
The FeatureDefinesCairo file should have been in the archive as a text file so that we can see diffs like we do for the FeatureDefines.props file. I've corrected that flag in this patch so that future updates will show nice diffs.
Created attachment 209275 [details] Patch 2 of 3 (WebCore Changes)
Created attachment 209277 [details] Patch 3 of 3 (Activate Tests)
Comment on attachment 209275 [details] Patch 2 of 3 (WebCore Changes) View in context: https://bugs.webkit.org/attachment.cgi?id=209275&action=review > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:13408 > + <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|x64'">true</ExcludedFromBuild> I don't know why Visual Studio does this kind of stuff. This is unrelated to my change. > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters:-3479 > - </ClCompile> Looks like VS found a duplicate entry and got rid of it. > Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters:-10548 > - </ClInclude> Ditto.
Patch 1 landed in https://trac.webkit.org/changeset/154390. Patch 2 landed in https://trac.webkit.org/changeset/154390
(In reply to comment #9) > Patch 2 landed in https://trac.webkit.org/changeset/154390 Patch 2 landed in https://trac.webkit.org/changeset/154391.
Committed r154392: <http://trac.webkit.org/changeset/154392>