Bug 120113 - [WINDOWS] Enable CSS_IMAGE_SET
Summary: [WINDOWS] Enable CSS_IMAGE_SET
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks: 120098
  Show dependency tree / graph
 
Reported: 2013-08-21 09:03 PDT by Brent Fulgham
Modified: 2013-08-21 09:58 PDT (History)
8 users (show)

See Also:

Attachments
Patch (33.38 KB, patch)
2013-08-21 09:13 PDT, Brent Fulgham 		no flags Details | Formatted Diff | Diff
Patch 1 of 3 (Build Settings) (6.87 KB, patch)
2013-08-21 09:15 PDT, Brent Fulgham 		andersca: review+
Details | Formatted Diff | Diff
Patch 2 of 3 (WebCore Changes) (11.17 KB, patch)
2013-08-21 09:36 PDT, Brent Fulgham 		andersca: review+
Details | Formatted Diff | Diff
Patch 3 of 3 (Activate Tests) (1.20 KB, patch)
2013-08-21 09:41 PDT, Brent Fulgham 		andersca: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2013-08-21 09:03:24 PDT 
Even though we don't have a lot of cases where the Windows ports need High DPI support, we need to at least be able to parse the -webkit-image-set markup and act appropriately. This is also important to getting proper behavior in the new Web Inspector.

This will become more important as more Windows devices are released with High DPI screens.

This patch activates the CSS_IMAGE_SET macro so that we properly handle these CSS features.
Comment 1 Radar WebKit Bug Importer 2013-08-21 09:03:55 PDT 
<rdar://problem/14796262>
Comment 2 Brent Fulgham 2013-08-21 09:13:51 PDT 
Created attachment 209271 [details]
Patch
Comment 3 Brent Fulgham 2013-08-21 09:15:57 PDT 
Created attachment 209272 [details]
Patch 1 of 3 (Build Settings)
Comment 4 Brent Fulgham 2013-08-21 09:16:59 PDT 
Comment on attachment 209272 [details]
Patch 1 of 3 (Build Settings)

I don't know why this file was improperly added to the archive. It's just a text file.
Comment 5 Brent Fulgham 2013-08-21 09:17:57 PDT 
The FeatureDefinesCairo file should have been in the archive as a text file so that we can see diffs like we do for the FeatureDefines.props file.  I've corrected that flag in this patch so that future updates will show nice diffs.
Comment 6 Brent Fulgham 2013-08-21 09:36:42 PDT 
Created attachment 209275 [details]
Patch 2 of 3 (WebCore Changes)
Comment 7 Brent Fulgham 2013-08-21 09:41:53 PDT 
Created attachment 209277 [details]
Patch 3 of 3 (Activate Tests)
Comment 8 Brent Fulgham 2013-08-21 09:45:20 PDT 
Comment on attachment 209275 [details]
Patch 2 of 3 (WebCore Changes)

View in context: https://bugs.webkit.org/attachment.cgi?id=209275&action=review

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj:13408
> +      <ExcludedFromBuild Condition="'$(Configuration)|$(Platform)'=='Production|x64'">true</ExcludedFromBuild>

I don't know why Visual Studio does this kind of stuff.  This is unrelated to my change.

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters:-3479
> -    </ClCompile>

Looks like VS found a duplicate entry and got rid of it.

> Source/WebCore/WebCore.vcxproj/WebCore.vcxproj.filters:-10548
> -    </ClInclude>

Ditto.
Comment 9 Brent Fulgham 2013-08-21 09:55:12 PDT 
Patch 1 landed in https://trac.webkit.org/changeset/154390.
Patch 2 landed in https://trac.webkit.org/changeset/154390
Comment 10 Brent Fulgham 2013-08-21 09:55:53 PDT 
(In reply to comment #9)
> Patch 2 landed in https://trac.webkit.org/changeset/154390

Patch 2 landed in https://trac.webkit.org/changeset/154391.
Comment 11 Brent Fulgham 2013-08-21 09:58:00 PDT 
Committed r154392: <http://trac.webkit.org/changeset/154392>