Running UI process with -AppleLanguages argument no longer results in a matching localization in WebProcess. Also, WebKitTestRunner fails to set WebProcess localization to English. <rdar://problem/14787771>
Created attachment 209236 [details] proposed fix
Comment on attachment 209236 [details] proposed fix Attachment 209236 [details] did not pass mac-wk2-ews (mac-wk2): Output: http://webkit-queues.appspot.com/results/1513866 New failing tests: fast/workers/termination-with-port-messages.html
Created attachment 209263 [details] Archive of layout-test-results from webkit-ews-12 for mac-mountainlion-wk2 The attached test failures were seen while running run-webkit-tests on the mac-wk2-ews. Bot: webkit-ews-12 Port: mac-mountainlion-wk2 Platform: Mac OS X 10.8.4
Comment on attachment 209236 [details] proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=209236&action=review > Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm:425 > + RetainPtr<CFStringRef> cfLocalization = adoptCF(WKCopyCFLocalizationPreferredName(0)); > + CString localization = String(cfLocalization.get()).utf8(); > + CString appleLanguagesArgument = String::format("('%s')", localization.data()).utf8(); I don’t think we need all three local variables. Maybe get rid of cfLocalization? Why use String::format when concatenation has much better performance? I would write this single-line version: CString appleLangagesArgument = ("('" + String(adoptCF(WKCopyCFLocalizationPreferredName(0))) + "')").utf8();
Committed <http://trac.webkit.org/r154396>.