Bug 120093 - Remove getOwnPropertyDescriptor trap
Summary: Remove getOwnPropertyDescriptor trap
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-20 14:56 PDT by Gavin Barraclough
Modified: 2013-08-20 16:46 PDT (History)
8 users (show)

See Also:


Attachments
Fix (106.68 KB, patch)
2013-08-20 15:17 PDT, Gavin Barraclough
webkit-ews: commit-queue-
Details | Formatted Diff | Diff
Complete patch! (109.00 KB, patch)
2013-08-20 15:32 PDT, Gavin Barraclough
ggaren: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2013-08-20 14:56:45 PDT
All implementations of this method are now called via the method table, and equivalent in behaviour.
Remove all duplicate implementations (and the method table trap), and add a single member function implementation on JSObject.
Comment 1 Gavin Barraclough 2013-08-20 15:17:52 PDT
Created attachment 209233 [details]
Fix
Comment 2 Early Warning System Bot 2013-08-20 15:29:17 PDT
Comment on attachment 209233 [details]
Fix

Attachment 209233 [details] did not pass qt-wk2-ews (qt-wk2):
Output: http://webkit-queues.appspot.com/results/1523249
Comment 3 Gavin Barraclough 2013-08-20 15:32:32 PDT
Created attachment 209234 [details]
Complete patch!
Comment 4 Geoffrey Garen 2013-08-20 16:37:30 PDT
Comment on attachment 209234 [details]
Complete patch!

r=me
Comment 5 Gavin Barraclough 2013-08-20 16:46:12 PDT
Committed revision 154373.