Bug 120086 - REGRESSION (r154300): http/tests/security/cross-frame-access-getOwnPropertyDescriptor is failing or crashing on the bots
Summary: REGRESSION (r154300): http/tests/security/cross-frame-access-getOwnPropertyDe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords: InRadar, LayoutTestFailure
Depends on:
Blocks: 119995
  Show dependency tree / graph
 
Reported: 2013-08-20 13:58 PDT by Tim Horton
Modified: 2013-08-22 06:34 PDT (History)
5 users (show)

See Also:

Attachments
Fix (35.48 KB, patch)
2013-08-20 17:04 PDT, Gavin Barraclough 		ggaren: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-08-20 13:58:06 PDT 
From rniwa, in https://bugs.webkit.org/show_bug.cgi?id=119995:

It seems like this patch caused http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html to fail or crash:
http://webkit-test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=http%2Ftests%2Fsecurity%2Fcross-frame-access-getOwnPropertyDescriptor.html
Comment 1 Tim Horton 2013-08-20 14:08:43 PDT 
Failing expectation in http://trac.webkit.org/changeset/154357
Comment 2 Geoffrey Garen 2013-08-20 16:49:36 PDT 
<rdar://problem/14790912>
Comment 3 Gavin Barraclough 2013-08-20 17:04:08 PDT 
Created attachment 209238 [details]
Fix
Comment 4 Geoffrey Garen 2013-08-20 17:06:12 PDT 
Comment on attachment 209238 [details]
Fix

r=me
Comment 5 Gavin Barraclough 2013-08-20 23:05:10 PDT 
Committed revision 154379.
Comment 6 Alexey Proskuryakov 2013-08-20 23:36:34 PDT 
Is this patch expected to address the crashing aspect too?
Comment 7 Ryosuke Niwa 2013-08-20 23:42:54 PDT 
(In reply to comment #6)
> Is this patch expected to address the crashing aspect too?

The crash had been fixed in http://trac.webkit.org/changeset/154313.  Sorry, I should have clarified that earlier.