Bug 120081 - lint-test-expectations complains about a seemingly-legitimate override
Summary: lint-test-expectations complains about a seemingly-legitimate override
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-20 13:28 PDT by Tim Horton
Modified: 2017-06-08 20:57 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-08-20 13:28:55 PDT 
platform/mac/TestExpectations has the following pair of lines:

webkit.org/b/60731 ietestcenter/css3/grid/grid-items-003.htm [ ImageOnlyFailure ]
webkit.org/b/60731 [ MountainLion Release ] ietestcenter/css3/grid/grid-items-003.htm [ Pass ImageOnlyFailure ]

This seems like a reasonable override, but lint-test-expectations complains like so:

LayoutTests/platform/mac/TestExpectations:987 More specific entry for ietestcenter/css3/grid/grid-items-003.htm on line LayoutTests/platform/mac/TestExpectations:986 overrides line LayoutTests/platform/mac/TestExpectations:987. ietestcenter/css3/grid/grid-items-003.htm
Comment 1 Dirk Pranke 2013-08-20 13:48:08 PDT 
Two lines in the same file are not allowed to have overlapping sets of modifiers. You would have to change this to something like:

[Lion] .... [ ImageOnlyFailure]
[MountainLion Debug] ... [ ImageOnlyFailure ]
[ML Release] ... [ Pass ImageOnlyFailure ]

At one point fairly early on in the evolution of new-run-webkit-tests, there was logic so that a more specific set of modifiers could legally override a less-specific set of modifiers, but it was deemed that this made things too confusing and hard to maintain. I think the code for this may actually mostly still be in test_expectations.py, but I don't know that you'd want to change it.