Bug 120075 - REGRESSION (r128400): BBC4 website not displaying pictures
Summary: REGRESSION (r128400): BBC4 website not displaying pictures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Michael Saboff
URL: http://www.bbc.co.uk/bbcfour/best-of
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-20 11:06 PDT by Michael Saboff
Modified: 2013-08-20 11:46 PDT (History)
0 users

See Also:

Attachments
Patch (4.36 KB, patch)
2013-08-20 11:41 PDT, Michael Saboff 		oliver: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Michael Saboff 2013-08-20 11:06:15 PDT 
Javascript is used to process the image paths shown on http://www.bbc.co.uk/bbcfour/best-of.  As of r128400, that processing is not working.

It turns out that the array returned by RegExp.match gets reified after PutByVal write are done to the array, thus overwriting the modifications to the array.  This is due to the array indexing type being wrong for RegExpMatchesArray objects.  Currently it is ArrayWithArrayStorage and should be ArrayWithSlowPutArrayStorage.

Patch forthcoming.

<rdar://problem/14716775>
Comment 1 Michael Saboff 2013-08-20 11:41:14 PDT 
Created attachment 209211 [details]
Patch
Comment 2 Michael Saboff 2013-08-20 11:46:39 PDT 
Committed r154346: <http://trac.webkit.org/changeset/154346>