Bug 120067 - Remove getPropertyDescriptor
Summary: Remove getPropertyDescriptor
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Gavin Barraclough
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-20 07:20 PDT by Gavin Barraclough
Modified: 2013-08-20 10:11 PDT (History)
2 users (show)

See Also:

Attachments
Fix (6.82 KB, patch)
2013-08-20 07:27 PDT, Gavin Barraclough 		oliver: review+
gtk-ews: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Gavin Barraclough 2013-08-20 07:20:51 PDT 
This is used by lookupGetter/lookupSetter – this can easily bee replaced by getPropertySlot.
Since we'll be getting the GetterSetter from the slot in the setter case, rename isGetter() to isAccessor().
Comment 1 Gavin Barraclough 2013-08-20 07:27:44 PDT 
Created attachment 209194 [details]
Fix
Comment 2 kov's GTK+ EWS bot 2013-08-20 08:27:28 PDT 
Comment on attachment 209194 [details]
Fix

Attachment 209194 [details] did not pass gtk-ews (gtk):
Output: http://webkit-queues.appspot.com/results/1514595
Comment 3 Oliver Hunt 2013-08-20 09:52:01 PDT 
Comment on attachment 209194 [details]
Fix

View in context: https://bugs.webkit.org/attachment.cgi?id=209194&action=review

Fix gtk before landing

> Source/JavaScriptCore/ChangeLog:8
> +        This is used by lookupGetter/lookupSetter â this can easily bee replaced by getPropertySlot.

no unicode!!!
Comment 4 Gavin Barraclough 2013-08-20 10:11:27 PDT 
Committed revision 154337.