Bug 120060 - [Qt][WK2] Doesn't build without Plugin-process
Summary: [Qt][WK2] Doesn't build without Plugin-process
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Allan Sandfeld Jensen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-20 02:40 PDT by Allan Sandfeld Jensen
Modified: 2013-08-20 03:43 PDT (History)
6 users (show)

See Also:

Attachments
Patch (1.30 KB, patch)
2013-08-20 02:43 PDT, Allan Sandfeld Jensen 		no flags Details | Formatted Diff | Diff
Patch (1.37 KB, patch)
2013-08-20 03:14 PDT, Allan Sandfeld Jensen 		jturcotte: review+
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Allan Sandfeld Jensen 2013-08-20 02:40:44 PDT 
In Qt we enable netscape-plugin-api on Mac and Windows for WebKit1, but do not enable plugin-process since we do not support plugins on mac and win in WebKit2. This configuration currently does not build.
Comment 1 Allan Sandfeld Jensen 2013-08-20 02:43:06 PDT 
Created attachment 209176 [details]
Patch
Comment 2 Allan Sandfeld Jensen 2013-08-20 03:14:23 PDT 
Created attachment 209178 [details]
Patch
Comment 3 Jocelyn Turcotte 2013-08-20 03:19:44 PDT 
Comment on attachment 209178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209178&action=review

> Source/WebKit2/Target.pri:18
> +enable?(netscape_plugin_api):enable?(plugin_architecture_unsupported) {

enable?(plugin_architecture_unsupported) doesn't read quite well, but well, a hack is a hack.

r=me
Comment 4 Allan Sandfeld Jensen 2013-08-20 03:43:30 PDT 
Committed r154321: <http://trac.webkit.org/changeset/154321>