Bug 120037 - Name getters on a document can get polluted by elements in shadow DOM
Summary: Name getters on a document can get polluted by elements in shadow DOM
Status: RESOLVED CONFIGURATION CHANGED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: BlinkMergeCandidate
Depends on:
Blocks:
 
Reported: 2013-08-19 17:16 PDT by Ryosuke Niwa
Modified: 2022-08-19 14:35 PDT (History)
6 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2013-08-19 17:16:05 PDT 
We need to partially merge https://codereview.chromium.org/22508006 so that we don't register ids and names of elements inside author shadow DOMs.
Comment 1 Ahmad Saleem 2022-08-19 14:35:15 PDT 
Element.h:

ADDED -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/Element.h#L61

ADDED -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/Element.h#L701

ADDED -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/Element.h#L707

Element.cpp

ADDED -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/Element.cpp#L4407

Missing Asserts:

ASSERT(document()->isHTMLDocument());

For:

updateNamedItemRegistration
updateExtraNamedItemRegistration

ADDED Partially or with changes -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/Element.cpp#L4153

ADDED with changes -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/Element.cpp#L4142

ADDED -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/Element.cpp#L4125

ADDED with changes -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/Element.cpp#L4074

TreeScope.h:

ADDED with changes -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/TreeScope.h#L63

ADDED with changes -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/TreeScope.h#L135

ADDED with changes -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/TreeScope.h#L155

TreeScope.cpp:

ADDED with change -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/TreeScope.cpp#L56

ADDED with changes -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/TreeScope.cpp#L132

ADDED -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/dom/TreeScope.cpp#L159

ReplaceNodeWithSpanCommand.cpp:

ADDED -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp#L50

ADDED with no ASSERT -> https://github.com/WebKit/WebKit/blob/a3bf99245a91d13466e4cf801e0e76e4bdce2f31/Source/WebCore/editing/ReplaceNodeWithSpanCommand.cpp#L56

_____

I think this was merge more or less. So I am going to mark this as "RESOLVED CONFIGURATION CHANGED". Please reopen, if needed. Thanks!