RESOLVED FIXED 120031
isReplacementObscured is wrong when the indicator is clipped by an iframe 
https://bugs.webkit.org/show_bug.cgi?id=120031
Summary isReplacementObscured is wrong when the indicator is clipped by an iframe
Tim Horton
Reported 2013-08-19 15:48:48 PDT
RenderEmbeddedObject::isReplacementObscured uses HitTestRequest::IgnoreClipping when hit-testing, causing it to be wrong in light of things like <iframe>. <rdar://problem/14606819>
Attachments
patch (8.04 KB, patch)
2013-08-19 19:19 PDT, Tim Horton 		simon.fraser: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2013-08-19 16:19:37 PDT
Actually, we can't not IgnoreClipping, that breaks lots of the other tests. Really what we need to do is climb up the document tree and hit-test from the main document, not from the iframe's document.
Tim Horton
Comment 2 2013-08-19 16:19:54 PDT
The intended behavior gets a bit complicated with scrolling.
Tim Horton
Comment 3 2013-08-19 19:19:47 PDT
Created attachment 209149 [details] patch a little bit concerned about the LayoutRect->IntRect bit.
Tim Horton
Comment 4 2013-08-21 14:02:55 PDT
http://trac.webkit.org/changeset/154412
Note You need to log in before you can comment on or make changes to this bug.