Bug 120031 - isReplacementObscured is wrong when the indicator is clipped by an iframe
Summary: isReplacementObscured is wrong when the indicator is clipped by an iframe
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Plug-ins (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2013-08-19 15:48 PDT by Tim Horton
Modified: 2013-08-21 14:02 PDT (History)
8 users (show)

See Also:


Attachments
patch (8.04 KB, patch)
2013-08-19 19:19 PDT, Tim Horton
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2013-08-19 15:48:48 PDT
RenderEmbeddedObject::isReplacementObscured uses HitTestRequest::IgnoreClipping when hit-testing, causing it to be wrong in light of things like <iframe>.

<rdar://problem/14606819>
Comment 1 Tim Horton 2013-08-19 16:19:37 PDT
Actually, we can't not IgnoreClipping, that breaks lots of the other tests.

Really what we need to do is climb up the document tree and hit-test from the main document, not from the iframe's document.
Comment 2 Tim Horton 2013-08-19 16:19:54 PDT
The intended behavior gets a bit complicated with scrolling.
Comment 3 Tim Horton 2013-08-19 19:19:47 PDT
Created attachment 209149 [details]
patch

a little bit concerned about the LayoutRect->IntRect bit.
Comment 4 Tim Horton 2013-08-21 14:02:55 PDT
http://trac.webkit.org/changeset/154412