Bug 120028 - ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get() when navigating to an uncached subframe
Summary: ASSERTION FAILED: m_history->provisionalItem() == m_requestedHistoryItem.get(...
Alias: None
Product: WebKit
Classification: Unclassified
Component: History (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Alexey Proskuryakov
Depends on:
Blocks: 120105
  Show dependency treegraph
Reported: 2013-08-19 14:02 PDT by Alexey Proskuryakov
Modified: 2013-08-20 23:35 PDT (History)
3 users (show)

See Also:

proposed fix (8.16 KB, patch)
2013-08-19 14:18 PDT, Alexey Proskuryakov
beidson: review+
Details | Formatted Diff | Diff
also delete unneeded code (10.85 KB, patch)
2013-08-19 15:12 PDT, Alexey Proskuryakov
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alexey Proskuryakov 2013-08-19 14:02:24 PDT
As seen in bug 119915, caching failure results in an assertion here. This can happen in normal browsing too, not only in WKTR.
Comment 1 Alexey Proskuryakov 2013-08-19 14:18:53 PDT
Created attachment 209123 [details]
proposed fix

It's not super clear to me whether it's intentional or a mistake that this variable is not set for subframes.

The only other place where it is used is HistoryController::restoreDocumentState(), and I couldn't make a test case that would show any effect this patch could have on form value restoration. Hopefully, there is no effect.
Comment 2 Alexey Proskuryakov 2013-08-19 15:12:04 PDT
Created attachment 209130 [details]
also delete unneeded code
Comment 3 WebKit Commit Bot 2013-08-19 16:40:13 PDT
Comment on attachment 209130 [details]
also delete unneeded code

Clearing flags on attachment: 209130

Committed r154306: <http://trac.webkit.org/changeset/154306>
Comment 4 WebKit Commit Bot 2013-08-19 16:40:15 PDT
All reviewed patches have been landed.  Closing bug.