Bug 120027 - AXObjectCache's accessibilityEnhancedUserInterfaceEnabled should be initialized on process creation
Summary: AXObjectCache's accessibilityEnhancedUserInterfaceEnabled should be initializ...
Alias: None
Product: WebKit
Classification: Unclassified
Component: Accessibility (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified OS X 10.8
: P2 Normal
Assignee: Beth Dakin
Keywords: InRadar
Depends on:
Reported: 2013-08-19 14:00 PDT by Beth Dakin
Modified: 2013-08-19 14:53 PDT (History)
5 users (show)

See Also:

Patch (4.53 KB, patch)
2013-08-19 14:05 PDT, Beth Dakin
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Beth Dakin 2013-08-19 14:00:36 PDT
Right now we only call AXObjectCache::setEnhancedAccessibility() when AppKit sends us a notification indicating that the value has changed. We should not have to rely on that to properly initialize this value.

Comment 1 Beth Dakin 2013-08-19 14:05:48 PDT
Created attachment 209120 [details]
Comment 2 chris fleizach 2013-08-19 14:16:06 PDT
Comment on attachment 209120 [details]

looks good to me
Comment 3 Sam Weinig 2013-08-19 14:43:47 PDT
Comment on attachment 209120 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=209120&action=review

> Source/WebKit2/WebProcess/mac/WebProcessMac.mm:188
> +    AXObjectCache::setEnhancedUserInterfaceAccessibility(parameters.accessibilityEnhancedUserInterfaceEnabled);

You can call setEnhancedAccessibility(parameters.accessibilityEnhancedUserInterfaceEnabled) here instead.
Comment 4 Beth Dakin 2013-08-19 14:53:57 PDT
Thanks, Sam! http://trac.webkit.org/changeset/154302