RESOLVED FIXED 120019
Document::visitedLinkState() should return a reference 
https://bugs.webkit.org/show_bug.cgi?id=120019
Summary Document::visitedLinkState() should return a reference
Pratik Solanki
Reported 2013-08-19 12:06:05 PDT
m_visitedLinkState is created in Document ctor and never cleared. We can return a reference from visitedLinkState() instead of a pointer.
Attachments
Patch (4.12 KB, patch)
2013-08-19 12:11 PDT, Pratik Solanki 		kling: review+
kling: commit-queue-
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Pratik Solanki
Comment 1 2013-08-19 12:11:20 PDT
Created attachment 209106 [details] Patch
Andreas Kling
Comment 2 2013-08-19 12:14:01 PDT
Comment on attachment 209106 [details] Patch r=me As an added precaution, you should make Document::m_visitedLinkState const. That way it can't be assigned to outside of the Document ctor initializer list.
Pratik Solanki
Comment 3 2013-08-19 12:43:15 PDT
Committed r154291: <http://trac.webkit.org/changeset/154291>
Note You need to log in before you can comment on or make changes to this bug.