Bug 120017 - Remove NodeRenderingTraversal::ParentDetails
Summary: Remove NodeRenderingTraversal::ParentDetails
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: DOM (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-19 10:50 PDT by Antti Koivisto
Modified: 2013-08-20 08:27 PDT (History)
8 users (show)

See Also:

Attachments
patch (21.83 KB, patch)
2013-08-19 12:41 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-08-19 10:50:45 PDT 
Remove this oddly factored type that is used to optionally collect some data during ComposedShadowTreeWalker parent traversal.
Comment 1 Antti Koivisto 2013-08-19 12:41:57 PDT 
Created attachment 209109 [details]
patch
Comment 2 Andreas Kling 2013-08-19 22:24:15 PDT 
Comment on attachment 209109 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209109&action=review

r=me

> Source/WebCore/css/StyleResolver.cpp:-834
> -    if (state.distributedToInsertionPoint()) {
> -        if (Element* parent = element->parentElement()) {
> -            if (RenderStyle* styleOfShadowHost = parent->renderStyle())
> -                state.style()->setUserModify(styleOfShadowHost->userModify());
> -        }
> -    }

Heh, I was here just the other day trying to figure out how to reach this code.
Comment 3 Antti Koivisto 2013-08-20 08:27:13 PDT 
https://trac.webkit.org/r154327