Bug 120002 - [CSS Masking] Add -webkit-mask-source-type shorthand property
Summary: [CSS Masking] Add -webkit-mask-source-type shorthand property
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-19 01:20 PDT by Andrei Parvu
Modified: 2013-08-28 07:09 PDT (History)
7 users (show)

See Also:

Attachments
Patch (7.35 KB, patch)
2013-08-19 01:37 PDT, Andrei Parvu 		no flags Details | Formatted Diff | Diff
Patch (7.22 KB, patch)
2013-08-28 05:11 PDT, Andrei Parvu 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andrei Parvu 2013-08-19 01:20:16 PDT 
We want to add the -webkit-mask-source-type property to the -webkit-mask shorthand property.
Comment 1 Andrei Parvu 2013-08-19 01:37:41 PDT 
Created attachment 209066 [details]
Patch
Comment 2 Dirk Schulze 2013-08-28 03:52:11 PDT 
Comment on attachment 209066 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209066&action=review

Looks good to me. Just some snippets.

> Source/WebCore/css/CSSParser.cpp:2847
> +        const CSSPropertyID properties[] = { CSSPropertyWebkitMaskImage, CSSPropertyWebkitMaskRepeat, CSSPropertyWebkitMaskSourceType,

Put this right after MaskImage to match the spec please.

> Source/WebCore/css/StylePropertyShorthand.cpp:441
> +        CSSPropertyWebkitMaskSourceType

Put this right after MaskImage to match the spec please.

> Source/WebCore/css/StylePropertyShorthand.cpp:888
> +        map.set(CSSPropertyWebkitMaskSourceType, mask);

Ditto.
Comment 3 Andrei Parvu 2013-08-28 05:11:41 PDT 
Created attachment 209866 [details]
Patch
Comment 4 Dirk Schulze 2013-08-28 06:47:24 PDT 
Comment on attachment 209866 [details]
Patch

r=me
Comment 5 WebKit Commit Bot 2013-08-28 07:09:45 PDT 
Comment on attachment 209866 [details]
Patch

Clearing flags on attachment: 209866

Committed r154742: <http://trac.webkit.org/changeset/154742>
Comment 6 WebKit Commit Bot 2013-08-28 07:09:47 PDT 
All reviewed patches have been landed.  Closing bug.