Bug 120001 - Clean up StyleElement
Summary: Clean up StyleElement
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2013-08-19 01:10 PDT by Antti Koivisto
Modified: 2013-08-19 01:56 PDT (History)
8 users (show)

See Also:

Attachments
patch (14.22 KB, patch)
2013-08-19 01:28 PDT, Antti Koivisto 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Antti Koivisto 2013-08-19 01:10:10 PDT 
It has some issues.
Comment 1 Antti Koivisto 2013-08-19 01:28:54 PDT 
Created attachment 209065 [details]
patch
Comment 2 Andreas Kling 2013-08-19 01:45:54 PDT 
Comment on attachment 209065 [details]
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=209065&action=review

r=me

(Wow, process -> createSheetFromTextContents.)

> Source/WebCore/dom/StyleElement.cpp:119
> +    if  (type.isEmpty())

Two spaces!?

> Source/WebCore/dom/StyleElement.cpp:147
> +    MediaQueryEvaluator screenEval("screen", true);
> +    MediaQueryEvaluator printEval("print", true);

Something, something, ASCIILiteral.
Comment 3 Andreas Kling 2013-08-19 01:46:13 PDT 
StyleElement is still a terrible name.
Comment 4 Antti Koivisto 2013-08-19 01:55:37 PDT 
http://trac.webkit.org/changeset/154268
Comment 5 Antti Koivisto 2013-08-19 01:56:13 PDT 
Yeah an(In reply to comment #3)
> StyleElement is still a terrible name.

Yeah and it should be used as a member, not inherited from.