RESOLVED FIXED120001
Clean up StyleElement 
https://bugs.webkit.org/show_bug.cgi?id=120001
Summary Clean up StyleElement
Antti Koivisto
Reported 2013-08-19 01:10:10 PDT
It has some issues.
Attachments
patch (14.22 KB, patch)
2013-08-19 01:28 PDT, Antti Koivisto 		kling: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2013-08-19 01:28:54 PDT
Created attachment 209065 [details] patch
Andreas Kling
Comment 2 2013-08-19 01:45:54 PDT
Comment on attachment 209065 [details] patch View in context: https://bugs.webkit.org/attachment.cgi?id=209065&action=review r=me (Wow, process -> createSheetFromTextContents.) > Source/WebCore/dom/StyleElement.cpp:119 > + if (type.isEmpty()) Two spaces!? > Source/WebCore/dom/StyleElement.cpp:147 > + MediaQueryEvaluator screenEval("screen", true); > + MediaQueryEvaluator printEval("print", true); Something, something, ASCIILiteral.
Andreas Kling
Comment 3 2013-08-19 01:46:13 PDT
StyleElement is still a terrible name.
Antti Koivisto
Comment 4 2013-08-19 01:55:37 PDT
http://trac.webkit.org/changeset/154268
Antti Koivisto
Comment 5 2013-08-19 01:56:13 PDT
Yeah an(In reply to comment #3) > StyleElement is still a terrible name. Yeah and it should be used as a member, not inherited from.
Note You need to log in before you can comment on or make changes to this bug.